Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2875773002:
Remove V8PerIsolateData::EnsureLiveRoot. (Closed)
|
Created:
3 years, 7 months ago by jbroman Modified:
3 years, 7 months ago Reviewers:
Michael Lippautz CC:
blink-reviews, chromium-reviews, kinuko+watch Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove V8PerIsolateData::EnsureLiveRoot.
It is dead code since https://codereview.chromium.org/2640963007.
Review-Url: https://codereview.chromium.org/2875773002
Cr-Commit-Position: refs/heads/master@{#471563}
Committed: https://chromium.googlesource.com/chromium/src/+/13876f5441f3660a99f4a92b118512e87359deb3
Patch Set 1 #
Messages
Total messages: 24 (14 generated)
The CQ bit was checked by jbroman@chromium.org to run a CQ dry run
jbroman@chromium.org changed reviewers: + mlippautz@chromium.org
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
LGTM
The CQ bit was checked by jbroman@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jbroman@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jbroman@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by jbroman@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494652853343400, "parent_rev":
"165ea5770f4a008b149dec4706989344d6a61803", "commit_rev":
"13876f5441f3660a99f4a92b118512e87359deb3"}
Message was sent while issue was closed.
Description was changed from ========== Remove V8PerIsolateData::EnsureLiveRoot. It is dead code since https://codereview.chromium.org/2640963007. ========== to ========== Remove V8PerIsolateData::EnsureLiveRoot. It is dead code since https://codereview.chromium.org/2640963007. Review-Url: https://codereview.chromium.org/2875773002 Cr-Commit-Position: refs/heads/master@{#471563} Committed: https://chromium.googlesource.com/chromium/src/+/13876f5441f3660a99f4a92b1185... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/13876f5441f3660a99f4a92b1185... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
