Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1211)

Side by Side Diff: third_party/WebKit/Source/platform/bindings/V8PerIsolateData.h

Issue 2875773002: Remove V8PerIsolateData::EnsureLiveRoot. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/bindings/V8PerIsolateData.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 static void Destroy(v8::Isolate*); 113 static void Destroy(v8::Isolate*);
114 static v8::Isolate* MainThreadIsolate(); 114 static v8::Isolate* MainThreadIsolate();
115 115
116 static void EnableIdleTasks(v8::Isolate*, 116 static void EnableIdleTasks(v8::Isolate*,
117 std::unique_ptr<gin::V8IdleTaskRunner>); 117 std::unique_ptr<gin::V8IdleTaskRunner>);
118 118
119 v8::Isolate* GetIsolate() { return isolate_holder_.isolate(); } 119 v8::Isolate* GetIsolate() { return isolate_holder_.isolate(); }
120 120
121 StringCache* GetStringCache() { return string_cache_.get(); } 121 StringCache* GetStringCache() { return string_cache_.get(); }
122 122
123 v8::Persistent<v8::Value>& EnsureLiveRoot();
124
125 bool IsHandlingRecursionLevelError() const { 123 bool IsHandlingRecursionLevelError() const {
126 return is_handling_recursion_level_error_; 124 return is_handling_recursion_level_error_;
127 } 125 }
128 void SetIsHandlingRecursionLevelError(bool value) { 126 void SetIsHandlingRecursionLevelError(bool value) {
129 is_handling_recursion_level_error_ = value; 127 is_handling_recursion_level_error_ = value;
130 } 128 }
131 129
132 bool IsReportingException() const { return is_reporting_exception_; } 130 bool IsReportingException() const { return is_reporting_exception_; }
133 void SetReportingException(bool value) { is_reporting_exception_ = value; } 131 void SetReportingException(bool value) { is_reporting_exception_ = value; }
134 132
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
246 // m_operationTemplateMapFor{,Non}MainWorld holds function templates for 244 // m_operationTemplateMapFor{,Non}MainWorld holds function templates for
247 // the cross-origin accessible DOM operations. 245 // the cross-origin accessible DOM operations.
248 V8FunctionTemplateMap operation_template_map_for_main_world_; 246 V8FunctionTemplateMap operation_template_map_for_main_world_;
249 V8FunctionTemplateMap operation_template_map_for_non_main_world_; 247 V8FunctionTemplateMap operation_template_map_for_non_main_world_;
250 248
251 // Contains lists of eternal names, such as dictionary keys. 249 // Contains lists of eternal names, such as dictionary keys.
252 HashMap<const void*, Vector<v8::Eternal<v8::Name>>> eternal_name_cache_; 250 HashMap<const void*, Vector<v8::Eternal<v8::Name>>> eternal_name_cache_;
253 251
254 std::unique_ptr<StringCache> string_cache_; 252 std::unique_ptr<StringCache> string_cache_;
255 std::unique_ptr<V8PrivateProperty> private_property_; 253 std::unique_ptr<V8PrivateProperty> private_property_;
256 ScopedPersistent<v8::Value> live_root_;
257 RefPtr<ScriptState> script_regexp_script_state_; 254 RefPtr<ScriptState> script_regexp_script_state_;
258 255
259 bool constructor_mode_; 256 bool constructor_mode_;
260 friend class ConstructorMode; 257 friend class ConstructorMode;
261 258
262 bool use_counter_disabled_; 259 bool use_counter_disabled_;
263 friend class UseCounterDisabledScope; 260 friend class UseCounterDisabledScope;
264 261
265 bool is_handling_recursion_level_error_; 262 bool is_handling_recursion_level_error_;
266 bool is_reporting_exception_; 263 bool is_reporting_exception_;
267 264
268 Vector<std::unique_ptr<EndOfScopeTask>> end_of_scope_tasks_; 265 Vector<std::unique_ptr<EndOfScopeTask>> end_of_scope_tasks_;
269 std::unique_ptr<Data> thread_debugger_; 266 std::unique_ptr<Data> thread_debugger_;
270 267
271 Persistent<ActiveScriptWrappableSet> active_script_wrappables_; 268 Persistent<ActiveScriptWrappableSet> active_script_wrappables_;
272 std::unique_ptr<ScriptWrappableVisitor> script_wrappable_visitor_; 269 std::unique_ptr<ScriptWrappableVisitor> script_wrappable_visitor_;
273 }; 270 };
274 271
275 } // namespace blink 272 } // namespace blink
276 273
277 #endif // V8PerIsolateData_h 274 #endif // V8PerIsolateData_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/bindings/V8PerIsolateData.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698