Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: third_party/WebKit/Source/platform/bindings/V8PerIsolateData.cpp

Issue 2875773002: Remove V8PerIsolateData::EnsureLiveRoot. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/bindings/V8PerIsolateData.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/bindings/V8PerIsolateData.cpp
diff --git a/third_party/WebKit/Source/platform/bindings/V8PerIsolateData.cpp b/third_party/WebKit/Source/platform/bindings/V8PerIsolateData.cpp
index e9f59763e1d8b529a087d2ebbf12d64c4e4a18e3..19eee733f61eadc76f64c8a9cac86fa1179742cb 100644
--- a/third_party/WebKit/Source/platform/bindings/V8PerIsolateData.cpp
+++ b/third_party/WebKit/Source/platform/bindings/V8PerIsolateData.cpp
@@ -91,12 +91,6 @@ void V8PerIsolateData::EnableIdleTasks(
From(isolate)->isolate_holder_.EnableIdleTasks(std::move(task_runner));
}
-v8::Persistent<v8::Value>& V8PerIsolateData::EnsureLiveRoot() {
- if (live_root_.IsEmpty())
- live_root_.Set(GetIsolate(), v8::Null(GetIsolate()));
- return live_root_.Get();
-}
-
// willBeDestroyed() clear things that should be cleared before
// ThreadState::detach() gets called.
void V8PerIsolateData::WillBeDestroyed(v8::Isolate* isolate) {
@@ -120,7 +114,6 @@ void V8PerIsolateData::Destroy(v8::Isolate* isolate) {
// Clear everything before exiting the Isolate.
if (data->script_regexp_script_state_)
data->script_regexp_script_state_->DisposePerContextData();
- data->live_root_.Clear();
data->private_property_.reset();
data->string_cache_->Dispose();
data->string_cache_.reset();
« no previous file with comments | « third_party/WebKit/Source/platform/bindings/V8PerIsolateData.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698