Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Unified Diff: chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.h

Issue 2874933008: Adds animation as feature variation to keyboard accessory. (Closed)
Patch Set: Merge forward Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.h
diff --git a/chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.h b/chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.h
index 47a2d77d8f69f7ae0057c5eb131b0ba69f9dcc9e..9257dc7bb9de202adb675bd9b07b0ee45b2303c9 100644
--- a/chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.h
+++ b/chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.h
@@ -20,11 +20,13 @@ class AutofillPopupController;
// A suggestion view that acts as an alternative to the field-attached popup
// window. This view appears above the keyboard and spans the width of the
-// screen, condensing rather than overlaying the content area. Enable via
-// --enable-autofill-keyboard-accessory-view.
+// screen, condensing rather than overlaying the content area.
class AutofillKeyboardAccessoryView : public AutofillPopupView {
public:
- explicit AutofillKeyboardAccessoryView(AutofillPopupController* controller);
+ AutofillKeyboardAccessoryView(AutofillPopupController* controller,
+ unsigned int animation_duration_millis,
please use gerrit instead 2017/05/15 14:37:29 Let's keep signedness consistent throughout. This
csashi 2017/05/15 20:07:26 Done.
+ bool should_limit_label_width,
+ bool is_first_suggestion_a_hint);
// --------------------------------------------------------------------------
// Methods called from Java via JNI
@@ -59,6 +61,16 @@ class AutofillKeyboardAccessoryView : public AutofillPopupView {
AutofillPopupController* controller_; // weak.
+ const int animation_duration_millis_; // If 0, don't animate suggestion view.
+
+ // If true, limits label width to 1/2 device's pixel width.
+ const bool should_limit_label_width_;
+
+ // If true and |animation_duration_millis_| > 0, we reverse the animation and
+ // scroll the first suggestion (which is a non-fillable hint) out of the
+ // viewport at the end of the reversed animation.
+ const bool is_first_suggestion_a_hint_;
+
// The index of the last item the user long-pressed (they will be shown a
// confirmation dialog).
int deleting_index_;

Powered by Google App Engine
This is Rietveld 408576698