Adds animation as feature variation to keyboard accessory.

chrome/browser/about_flags.cc

Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 4db353e1c4d3ce3f94b94e70e90d52a586841c54..4525fba94e28ea91b60f0eac3dcb8c31fbecc19a 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -39,6 +39,7 @@
 #include "chrome/grit/chromium_strings.h"
 #include "components/autofill/core/browser/autofill_experiments.h"
 #include "components/autofill/core/common/autofill_switches.h"
+#include "components/autofill/core/common/autofill_util.h"
 #include "components/browser_sync/browser_sync_switches.h"
 #include "components/cloud_devices/common/cloud_devices_switches.h"
 #include "components/data_reduction_proxy/core/common/data_reduction_proxy_features.h"
@@ -843,6 +844,40 @@ kAutofillCreditCardPopupLayoutFeatureVariations[] = {
      kAutofillCreditCardPopupLayoutFeatureVariationExpanded,
      arraysize(kAutofillCreditCardPopupLayoutFeatureVariationExpanded),
      nullptr}};
+
+const FeatureEntry::FeatureParam
+    kAutofillKeyboardAccessoryFeatureVariationAnimationDuration[] = {
+        {autofill::kAutofillKeyboardAccessoryAnimationDurationKey, "1000"}};
+
+const FeatureEntry::FeatureParam
+    kAutofillKeyboardAccessoryFeatureVariationLimitLabelWidth[] = {
+        {autofill::kAutofillKeyboardAccessoryLimitLabelWidthKey, "true"}};
+
+const FeatureEntry::FeatureParam
+    kAutofillKeyboardAccessoryFeatureVariationShowHint[] = {
+        {autofill::kAutofillKeyboardAccessoryHintKey, "true"}};
+
+const FeatureEntry::FeatureParam
+    kAutofillKeyboardAccessoryFeatureVariationAnimateWithHint[] = {
+        {autofill::kAutofillKeyboardAccessoryAnimationDurationKey, "1000"},
+        {autofill::kAutofillKeyboardAccessoryHintKey, "true"}};
+
+const FeatureEntry::FeatureVariation
+    kAutofillKeyboardAccessoryFeatureVariations[] = {
+        {"Animate", kAutofillKeyboardAccessoryFeatureVariationAnimationDuration,
+         arraysize(kAutofillKeyboardAccessoryFeatureVariationAnimationDuration),
+         nullptr},
+        {"Limit label width",
+         kAutofillKeyboardAccessoryFeatureVariationLimitLabelWidth,
+         arraysize(kAutofillKeyboardAccessoryFeatureVariationLimitLabelWidth),
+         nullptr},
+        {"Show hint", kAutofillKeyboardAccessoryFeatureVariationShowHint,
+         arraysize(kAutofillKeyboardAccessoryFeatureVariationShowHint),
+         nullptr},
+        {"Animate with hint",
+         kAutofillKeyboardAccessoryFeatureVariationAnimateWithHint,
+         arraysize(kAutofillKeyboardAccessoryFeatureVariationAnimateWithHint),
+         nullptr}};
 #endif  // OS_ANDROID
 
 const FeatureEntry::FeatureParam
@@ -1953,9 +1988,9 @@ const FeatureEntry kFeatureEntries[] = {
     {"enable-autofill-keyboard-accessory-view",

[please use gerrit instead, 2017/05/15 14:37:29]

Remove "enable-" part of the string?

[csashi, 2017/05/15 20:07:26]

Done.

      flag_descriptions::kAutofillAccessoryViewName,
      flag_descriptions::kAutofillAccessoryViewDescription, kOsAndroid,
-     ENABLE_DISABLE_VALUE_TYPE(
-         autofill::switches::kEnableAccessorySuggestionView,
-         autofill::switches::kDisableAccessorySuggestionView)},
+     FEATURE_WITH_PARAMS_VALUE_TYPE(autofill::kAutofillKeyboardAccessory,
+                                    kAutofillKeyboardAccessoryFeatureVariations,
+                                    "AutofillKeyboardAccessoryVariations")},
 #endif  // OS_ANDROID
 #if defined(OS_WIN)
     {"try-supported-channel-layouts",