Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Unified Diff: chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.cc

Issue 2874933008: Adds animation as feature variation to keyboard accessory. (Closed)
Patch Set: Merge forward Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.cc
diff --git a/chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.cc b/chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.cc
index 76591fc4ba6149b2ba768e11c7aec3274251d17c..68ee1eb7f3df17d8490cf078a455e3ff8ed67883 100644
--- a/chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.cc
+++ b/chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.cc
@@ -45,8 +45,15 @@ void AddToJavaArray(const Suggestion& suggestion,
} // namespace
AutofillKeyboardAccessoryView::AutofillKeyboardAccessoryView(
- AutofillPopupController* controller)
- : controller_(controller), deleting_index_(-1) {
+ AutofillPopupController* controller,
+ unsigned int animation_duration_millis,
+ bool should_limit_label_width,
+ bool is_first_suggestion_a_hint)
+ : controller_(controller),
+ animation_duration_millis_(animation_duration_millis),
+ should_limit_label_width_(should_limit_label_width),
+ is_first_suggestion_a_hint_(is_first_suggestion_a_hint),
+ deleting_index_(-1) {
JNIEnv* env = base::android::AttachCurrentThread();
java_object_.Reset(Java_AutofillKeyboardAccessoryBridge_create(env));
}
@@ -63,7 +70,9 @@ void AutofillKeyboardAccessoryView::Show() {
DCHECK(view_android);
Java_AutofillKeyboardAccessoryBridge_init(
env, java_object_, reinterpret_cast<intptr_t>(this),
- view_android->GetWindowAndroid()->GetJavaObject());
+ view_android->GetWindowAndroid()->GetJavaObject(),
+ animation_duration_millis_, should_limit_label_width_,
+ is_first_suggestion_a_hint_);
OnSuggestionsChanged();
}

Powered by Google App Engine
This is Rietveld 408576698