Adds animation as feature variation to keyboard accessory.

chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_ANDROID_AUTOFILL_AUTOFILL_KEYBOARD_ACCESSORY_VIEW_H_
 #define CHROME_BROWSER_UI_ANDROID_AUTOFILL_AUTOFILL_KEYBOARD_ACCESSORY_VIEW_H_
 
 #include <jni.h>
 #include <stddef.h>
 #include <vector>
 
 #include "base/android/scoped_java_ref.h"
 #include "base/compiler_specific.h"
 #include "base/macros.h"
 #include "chrome/browser/ui/autofill/autofill_popup_view.h"
 
 namespace autofill {
 
 class AutofillPopupController;
 
 // A suggestion view that acts as an alternative to the field-attached popup
 // window. This view appears above the keyboard and spans the width of the
-// screen, condensing rather than overlaying the content area. Enable via
-// --enable-autofill-keyboard-accessory-view.
+// screen, condensing rather than overlaying the content area.
 class AutofillKeyboardAccessoryView : public AutofillPopupView {
  public:
-  explicit AutofillKeyboardAccessoryView(AutofillPopupController* controller);
+  AutofillKeyboardAccessoryView(AutofillPopupController* controller,
+                                unsigned int animation_duration_millis,

[please use gerrit instead, 2017/05/15 14:37:29]

Let's keep signedness consistent throughout. This param is unsigned, but it's
stored into a signed member variable.

[csashi, 2017/05/15 20:07:26]

Done.

+                                bool should_limit_label_width,
+                                bool is_first_suggestion_a_hint);
 
   // --------------------------------------------------------------------------
   // Methods called from Java via JNI
   // --------------------------------------------------------------------------
   // Called when an autofill item was selected.
   void SuggestionSelected(JNIEnv* env,
                           const base::android::JavaParamRef<jobject>& obj,
                           jint list_index);
 
   void DeletionRequested(JNIEnv* env,
@@ skipping 14 matching lines @@
   void Hide() override;
   void OnSelectedRowChanged(base::Optional<int> previous_row_selection,
                             base::Optional<int> current_row_selection) override;
   void OnSuggestionsChanged() override;
 
  private:
   ~AutofillKeyboardAccessoryView() override;
 
   AutofillPopupController* controller_;  // weak.
 
+  const int animation_duration_millis_;  // If 0, don't animate suggestion view.
+
+  // If true, limits label width to 1/2 device's pixel width.
+  const bool should_limit_label_width_;
+
+  // If true and |animation_duration_millis_| > 0, we reverse the animation and
+  // scroll the first suggestion (which is a non-fillable hint) out of the
+  // viewport at the end of the reversed animation.
+  const bool is_first_suggestion_a_hint_;
+
   // The index of the last item the user long-pressed (they will be shown a
   // confirmation dialog).
   int deleting_index_;
 
   // Mapping from Java list index to autofill suggestion index.
   std::vector<int> positions_;
 
   // The corresponding java object.
   base::android::ScopedJavaGlobalRef<jobject> java_object_;
 
   DISALLOW_COPY_AND_ASSIGN(AutofillKeyboardAccessoryView);
 };
 
 }  // namespace autofill
 
 #endif  // CHROME_BROWSER_UI_ANDROID_AUTOFILL_AUTOFILL_KEYBOARD_ACCESSORY_VIEW_H_