Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 2872993003: Rename LowReputationPinging Feature to PasswordFieldOnFocusPinging (Closed)

Created:
3 years, 7 months ago by Jialiu Lin
Modified:
3 years, 7 months ago
CC:
chromium-reviews, grt+watch_chromium.org, lpz, timvolodine, vakh+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename LowReputationPinging Feature to PasswordFieldOnFocusPinging BUG=698899 Review-Url: https://codereview.chromium.org/2872993003 Cr-Commit-Position: refs/heads/master@{#470515} Committed: https://chromium.googlesource.com/chromium/src/+/a0202037a8eb837583119cdc388c1f04a6c4ab51

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -64 lines) Patch
M chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc View 5 chunks +58 lines, -57 lines 0 comments Download
M components/safe_browsing/password_protection/password_protection_service.h View 1 chunk +1 line, -1 line 0 comments Download
M components/safe_browsing/password_protection/password_protection_service.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M testing/variations/fieldtrial_testing_config.json View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 28 (17 generated)
Jialiu Lin
Hi lpz, Could you take a look at this tiny CL? No logic change, simply ...
3 years, 7 months ago (2017-05-09 21:41:01 UTC) #4
vakh (use Gerrit instead)
lgtm
3 years, 7 months ago (2017-05-09 22:25:27 UTC) #6
Jialiu Lin
Thanks for the quick lgtm, vakh@! (move lpz@ from reviewer to cc) lpz@, since there ...
3 years, 7 months ago (2017-05-09 22:37:30 UTC) #8
Jialiu Lin
+isherman@ for owner review of fieldtrial_testing_config.json Note that, there is no finch config file for ...
3 years, 7 months ago (2017-05-09 22:40:56 UTC) #11
Ilya Sherman
field trial testing config lgtm
3 years, 7 months ago (2017-05-09 23:04:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872993003/1
3 years, 7 months ago (2017-05-09 23:13:13 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; ...
3 years, 7 months ago (2017-05-10 01:16:33 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872993003/1
3 years, 7 months ago (2017-05-10 02:20:27 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; ...
3 years, 7 months ago (2017-05-10 04:22:45 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872993003/1
3 years, 7 months ago (2017-05-10 07:29:00 UTC) #25
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 07:36:17 UTC) #28
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a0202037a8eb837583119cdc388c...

Powered by Google App Engine
This is Rietveld 408576698