Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2483)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc

Issue 2872993003: Rename LowReputationPinging Feature to PasswordFieldOnFocusPinging (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/safe_browsing/password_protection/password_protection_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc
diff --git a/chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc b/chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc
index 03ec3dbd813154bb9cf279ecb609effc8dfb39b9..4152ac08f64bd5d858dc5bc2f2dd3315359dda23 100644
--- a/chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc
+++ b/chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc
@@ -74,11 +74,11 @@ class ChromePasswordProtectionServiceTest : public testing::Test {
TEST_F(ChromePasswordProtectionServiceTest,
VerifyFinchControlForLowReputationPingSBEROnlyNoIncognito) {
MockChromePasswordProtectionService service;
- // By default kLowReputationPinging feature is disabled.
- EXPECT_FALSE(service.IsPingingEnabled(kLowReputationPinging));
+ // By default kPasswordFieldOnFocusPinging feature is disabled.
+ EXPECT_FALSE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
- // Enables kLowReputationPinging feature.
- scoped_feature_list_.InitAndEnableFeature(kLowReputationPinging);
+ // Enables kPasswordFieldOnFocusPinging feature.
+ scoped_feature_list_.InitAndEnableFeature(kPasswordFieldOnFocusPinging);
// Creates finch trial parameters correspond to the following experiment:
// "name": "SBEROnlyNoIncognito",
// "params": {
@@ -87,38 +87,38 @@ TEST_F(ChromePasswordProtectionServiceTest,
// "history_sync": "false"
// },
// "enable_features": [
- // "LowReputationPinging"
+ // "PasswordFieldOnFocusPinging"
// ]
Parameters sber_and_no_incognito =
CreateParameters(false, false, true, false);
- SetFeatureParams(kLowReputationPinging, "SBEROnlyNoIncognito",
+ SetFeatureParams(kPasswordFieldOnFocusPinging, "SBEROnlyNoIncognito",
sber_and_no_incognito);
service.ConfigService(false /*incognito*/, false /*SBER*/, false /*sync*/);
- EXPECT_FALSE(service.IsPingingEnabled(kLowReputationPinging));
+ EXPECT_FALSE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
service.ConfigService(false /*incognito*/, false /*SBER*/, true /*sync*/);
- EXPECT_FALSE(service.IsPingingEnabled(kLowReputationPinging));
+ EXPECT_FALSE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
service.ConfigService(false /*incognito*/, true /*SBER*/, false /*sync*/);
- EXPECT_TRUE(service.IsPingingEnabled(kLowReputationPinging));
+ EXPECT_TRUE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
service.ConfigService(false /*incognito*/, true /*SBER*/, true /*sync*/);
- EXPECT_TRUE(service.IsPingingEnabled(kLowReputationPinging));
+ EXPECT_TRUE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
service.ConfigService(true /*incognito*/, false /*SBER*/, false /*sync*/);
- EXPECT_FALSE(service.IsPingingEnabled(kLowReputationPinging));
+ EXPECT_FALSE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
service.ConfigService(true /*incognito*/, false /*SBER*/, true /*sync*/);
- EXPECT_FALSE(service.IsPingingEnabled(kLowReputationPinging));
+ EXPECT_FALSE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
service.ConfigService(true /*incognito*/, true /*SBER*/, false /*sync*/);
- EXPECT_FALSE(service.IsPingingEnabled(kLowReputationPinging));
+ EXPECT_FALSE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
service.ConfigService(true /*incognito*/, true /*SBER*/, true /*sync*/);
- EXPECT_FALSE(service.IsPingingEnabled(kLowReputationPinging));
+ EXPECT_FALSE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
}
TEST_F(ChromePasswordProtectionServiceTest,
VerifyFinchControlForLowReputationPingSBERAndHistorySyncNoIncognito) {
MockChromePasswordProtectionService service;
- // By default kLowReputationPinging feature is disabled.
- EXPECT_FALSE(service.IsPingingEnabled(kLowReputationPinging));
+ // By default kPasswordFieldOnFocusPinging feature is disabled.
+ EXPECT_FALSE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
- // Enables kLowReputationPinging feature.
- scoped_feature_list_.InitAndEnableFeature(kLowReputationPinging);
+ // Enables kPasswordFieldOnFocusPinging feature.
+ scoped_feature_list_.InitAndEnableFeature(kPasswordFieldOnFocusPinging);
// Creates finch trial parameters correspond to the following experiment:
// "name": "SBERAndHistorySyncNoIncognito",
// "params": {
@@ -127,38 +127,38 @@ TEST_F(ChromePasswordProtectionServiceTest,
// "history_sync": "true"
// },
// "enable_features": [
- // "LowReputationPinging"
+ // "PasswordFieldOnFocusPinging"
// ]
Parameters sber_and_sync_no_incognito =
CreateParameters(false, false, true, true);
- SetFeatureParams(kLowReputationPinging, "SBERAndHistorySyncNoIncognito",
- sber_and_sync_no_incognito);
+ SetFeatureParams(kPasswordFieldOnFocusPinging,
+ "SBERAndHistorySyncNoIncognito", sber_and_sync_no_incognito);
service.ConfigService(false /*incognito*/, false /*SBER*/, false /*sync*/);
- EXPECT_FALSE(service.IsPingingEnabled(kLowReputationPinging));
+ EXPECT_FALSE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
service.ConfigService(false /*incognito*/, false /*SBER*/, true /*sync*/);
- EXPECT_TRUE(service.IsPingingEnabled(kLowReputationPinging));
+ EXPECT_TRUE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
service.ConfigService(false /*incognito*/, true /*SBER*/, false /*sync*/);
- EXPECT_TRUE(service.IsPingingEnabled(kLowReputationPinging));
+ EXPECT_TRUE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
service.ConfigService(false /*incognito*/, true /*SBER*/, true /*sync*/);
- EXPECT_TRUE(service.IsPingingEnabled(kLowReputationPinging));
+ EXPECT_TRUE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
service.ConfigService(true /*incognito*/, false /*SBER*/, false /*sync*/);
- EXPECT_FALSE(service.IsPingingEnabled(kLowReputationPinging));
+ EXPECT_FALSE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
service.ConfigService(true /*incognito*/, false /*SBER*/, true /*sync*/);
- EXPECT_FALSE(service.IsPingingEnabled(kLowReputationPinging));
+ EXPECT_FALSE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
service.ConfigService(true /*incognito*/, true /*SBER*/, false /*sync*/);
- EXPECT_FALSE(service.IsPingingEnabled(kLowReputationPinging));
+ EXPECT_FALSE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
service.ConfigService(true /*incognito*/, true /*SBER*/, true /*sync*/);
- EXPECT_FALSE(service.IsPingingEnabled(kLowReputationPinging));
+ EXPECT_FALSE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
}
TEST_F(ChromePasswordProtectionServiceTest,
VerifyFinchControlForLowReputationPingAllButNoIncognito) {
MockChromePasswordProtectionService service;
- // By default kLowReputationPinging feature is disabled.
- EXPECT_FALSE(service.IsPingingEnabled(kLowReputationPinging));
+ // By default kPasswordFieldOnFocusPinging feature is disabled.
+ EXPECT_FALSE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
- // Enables kLowReputationPinging feature.
- scoped_feature_list_.InitAndEnableFeature(kLowReputationPinging);
+ // Enables kPasswordFieldOnFocusPinging feature.
+ scoped_feature_list_.InitAndEnableFeature(kPasswordFieldOnFocusPinging);
// Creates finch trial parameters correspond to the following experiment:
// "name": "AllButNoIncognito",
// "params": {
@@ -166,36 +166,37 @@ TEST_F(ChromePasswordProtectionServiceTest,
// "incongito": "false"
// },
// "enable_features": [
- // "LowReputationPinging"
+ // "PasswordFieldOnFocusPinging"
// ]
Parameters all_users = CreateParameters(false, true, true, true);
- SetFeatureParams(kLowReputationPinging, "AllButNoIncognito", all_users);
+ SetFeatureParams(kPasswordFieldOnFocusPinging, "AllButNoIncognito",
+ all_users);
service.ConfigService(false /*incognito*/, false /*SBER*/, false /*sync*/);
- EXPECT_TRUE(service.IsPingingEnabled(kLowReputationPinging));
+ EXPECT_TRUE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
service.ConfigService(false /*incognito*/, false /*SBER*/, true /*sync*/);
- EXPECT_TRUE(service.IsPingingEnabled(kLowReputationPinging));
+ EXPECT_TRUE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
service.ConfigService(false /*incognito*/, true /*SBER*/, false /*sync*/);
- EXPECT_TRUE(service.IsPingingEnabled(kLowReputationPinging));
+ EXPECT_TRUE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
service.ConfigService(false /*incognito*/, true /*SBER*/, true /*sync*/);
- EXPECT_TRUE(service.IsPingingEnabled(kLowReputationPinging));
+ EXPECT_TRUE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
service.ConfigService(true /*incognito*/, false /*SBER*/, false /*sync*/);
- EXPECT_FALSE(service.IsPingingEnabled(kLowReputationPinging));
+ EXPECT_FALSE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
service.ConfigService(true /*incognito*/, false /*SBER*/, true /*sync*/);
- EXPECT_FALSE(service.IsPingingEnabled(kLowReputationPinging));
+ EXPECT_FALSE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
service.ConfigService(true /*incognito*/, true /*SBER*/, false /*sync*/);
- EXPECT_FALSE(service.IsPingingEnabled(kLowReputationPinging));
+ EXPECT_FALSE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
service.ConfigService(true /*incognito*/, true /*SBER*/, true /*sync*/);
- EXPECT_FALSE(service.IsPingingEnabled(kLowReputationPinging));
+ EXPECT_FALSE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
}
TEST_F(ChromePasswordProtectionServiceTest,
VerifyFinchControlForLowReputationPingAll) {
MockChromePasswordProtectionService service;
- // By default kLowReputationPinging feature is disabled.
- EXPECT_FALSE(service.IsPingingEnabled(kLowReputationPinging));
+ // By default kPasswordFieldOnFocusPinging feature is disabled.
+ EXPECT_FALSE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
- // Enables kLowReputationPinging feature.
- scoped_feature_list_.InitAndEnableFeature(kLowReputationPinging);
+ // Enables kPasswordFieldOnFocusPinging feature.
+ scoped_feature_list_.InitAndEnableFeature(kPasswordFieldOnFocusPinging);
// Creates finch trial parameters correspond to the following experiment:
// "name": "All",
// "params": {
@@ -203,26 +204,26 @@ TEST_F(ChromePasswordProtectionServiceTest,
// "incognito": "true"
// },
// "enable_features": [
- // "LowReputationPinging"
+ // "PasswordFieldOnFocusPinging"
// ]
Parameters all_users = CreateParameters(true, true, true, true);
- SetFeatureParams(kLowReputationPinging, "All", all_users);
+ SetFeatureParams(kPasswordFieldOnFocusPinging, "All", all_users);
service.ConfigService(false /*incognito*/, false /*SBER*/, false /*sync*/);
- EXPECT_TRUE(service.IsPingingEnabled(kLowReputationPinging));
+ EXPECT_TRUE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
service.ConfigService(false /*incognito*/, false /*SBER*/, true /*sync*/);
- EXPECT_TRUE(service.IsPingingEnabled(kLowReputationPinging));
+ EXPECT_TRUE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
service.ConfigService(false /*incognito*/, true /*SBER*/, false /*sync*/);
- EXPECT_TRUE(service.IsPingingEnabled(kLowReputationPinging));
+ EXPECT_TRUE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
service.ConfigService(false /*incognito*/, true /*SBER*/, true /*sync*/);
- EXPECT_TRUE(service.IsPingingEnabled(kLowReputationPinging));
+ EXPECT_TRUE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
service.ConfigService(true /*incognito*/, false /*SBER*/, false /*sync*/);
- EXPECT_TRUE(service.IsPingingEnabled(kLowReputationPinging));
+ EXPECT_TRUE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
service.ConfigService(true /*incognito*/, false /*SBER*/, true /*sync*/);
- EXPECT_TRUE(service.IsPingingEnabled(kLowReputationPinging));
+ EXPECT_TRUE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
service.ConfigService(true /*incognito*/, true /*SBER*/, false /*sync*/);
- EXPECT_TRUE(service.IsPingingEnabled(kLowReputationPinging));
+ EXPECT_TRUE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
service.ConfigService(true /*incognito*/, true /*SBER*/, true /*sync*/);
- EXPECT_TRUE(service.IsPingingEnabled(kLowReputationPinging));
+ EXPECT_TRUE(service.IsPingingEnabled(kPasswordFieldOnFocusPinging));
}
} // namespace safe_browsing
« no previous file with comments | « no previous file | components/safe_browsing/password_protection/password_protection_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698