Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1115)

Unified Diff: components/safe_browsing/password_protection/password_protection_service.cc

Issue 2872993003: Rename LowReputationPinging Feature to PasswordFieldOnFocusPinging (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing/password_protection/password_protection_service.cc
diff --git a/components/safe_browsing/password_protection/password_protection_service.cc b/components/safe_browsing/password_protection/password_protection_service.cc
index 32038372bb4d03e780fd3566b616531391888bc7..ee3af7cda3a1918f2f4612517faa78cbaa57bd5f 100644
--- a/components/safe_browsing/password_protection/password_protection_service.cc
+++ b/components/safe_browsing/password_protection/password_protection_service.cc
@@ -64,8 +64,8 @@ GURL GetHostNameWithHTTPScheme(const GURL& url) {
} // namespace
-const base::Feature kLowReputationPinging{"LowReputationPinging",
- base::FEATURE_DISABLED_BY_DEFAULT};
+const base::Feature kPasswordFieldOnFocusPinging{
+ "PasswordFieldOnFocusPinging", base::FEATURE_DISABLED_BY_DEFAULT};
const base::Feature kProtectedPasswordEntryPinging{
"ProtectedPasswordEntryPinging", base::FEATURE_DISABLED_BY_DEFAULT};
@@ -221,7 +221,7 @@ void PasswordProtectionService::MaybeStartLowReputationRequest(
const GURL& password_form_action,
const GURL& password_form_frame_url) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
- if (!IsPingingEnabled(kLowReputationPinging))
+ if (!IsPingingEnabled(kPasswordFieldOnFocusPinging))
return;
// Skip URLs that we can't get a reliable reputation for.
@@ -317,7 +317,7 @@ void PasswordProtectionService::FillUserPopulation(
user_population->set_is_history_sync_enabled(IsHistorySyncEnabled());
base::FieldTrial* low_reputation_field_trial =
- base::FeatureList::GetFieldTrial(kLowReputationPinging);
+ base::FeatureList::GetFieldTrial(kPasswordFieldOnFocusPinging);
if (low_reputation_field_trial) {
user_population->add_finch_active_groups(
low_reputation_field_trial->trial_name() + "|" +

Powered by Google App Engine
This is Rietveld 408576698