Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2872593004: webkitpy: Fix removing expectation lines. (Closed)

Created:
3 years, 7 months ago by mithro
Modified:
3 years, 6 months ago
Reviewers:
qyearsley
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

webkitpy: Fix removing expectation lines. BUG=719310 Review-Url: https://codereview.chromium.org/2872593004 Cr-Commit-Position: refs/heads/master@{#477594} Committed: https://chromium.googlesource.com/chromium/src/+/fe9de810db44d55b7638510750707a4c908143c8

Patch Set 1 #

Patch Set 2 : git diff origin/master #

Patch Set 3 : webkitpy: Fix removing expectation lines. #

Patch Set 4 : git cl try #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py View 1 2 4 chunks +13 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (9 generated)
qyearsley
This fix LGTM, although I guess we were missing test coverage before which would have ...
3 years, 7 months ago (2017-05-09 18:01:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2872593004/60001
3 years, 6 months ago (2017-06-07 09:21:51 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 09:26:47 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/fe9de810db44d55b763851075070...

Powered by Google App Engine
This is Rietveld 408576698