Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

Issue 2872593004: webkitpy: Fix removing expectation lines. (Closed)
Patch Set: git cl try Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # Copyright (C) 2010 Gabor Rapcsanyi (rgabor@inf.u-szeged.hu), University of Sze ged 2 # Copyright (C) 2010 Gabor Rapcsanyi (rgabor@inf.u-szeged.hu), University of Sze ged
3 # 3 #
4 # Redistribution and use in source and binary forms, with or without 4 # Redistribution and use in source and binary forms, with or without
5 # modification, are permitted provided that the following conditions are 5 # modification, are permitted provided that the following conditions are
6 # met: 6 # met:
7 # 7 #
8 # * Redistributions of source code must retain the above copyright 8 # * Redistributions of source code must retain the above copyright
9 # notice, this list of conditions and the following disclaimer. 9 # notice, this list of conditions and the following disclaimer.
10 # * Redistributions in binary form must reproduce the above 10 # * Redistributions in binary form must reproduce the above
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 all_test_names.sort() 121 all_test_names.sort()
122 random.Random(self._options.seed).shuffle(all_test_names) 122 random.Random(self._options.seed).shuffle(all_test_names)
123 123
124 test_names, tests_in_other_chunks = self._finder.split_into_chunks(all_t est_names) 124 test_names, tests_in_other_chunks = self._finder.split_into_chunks(all_t est_names)
125 125
126 self._printer.write_update('Parsing expectations ...') 126 self._printer.write_update('Parsing expectations ...')
127 self._expectations = test_expectations.TestExpectations(self._port, test _names) 127 self._expectations = test_expectations.TestExpectations(self._port, test _names)
128 128
129 tests_to_run, tests_to_skip = self._prepare_lists(paths, test_names) 129 tests_to_run, tests_to_skip = self._prepare_lists(paths, test_names)
130 130
131 self._expectations.remove_tests(tests_in_other_chunks) 131 self._expectations.remove_tests_from_expectations(tests_in_other_chunks)
132 132
133 self._printer.print_found( 133 self._printer.print_found(
134 len(all_test_names), len(test_names), len(tests_to_run), 134 len(all_test_names), len(test_names), len(tests_to_run),
135 self._options.repeat_each, self._options.iterations) 135 self._options.repeat_each, self._options.iterations)
136 136
137 # Check to make sure we're not skipping every test. 137 # Check to make sure we're not skipping every test.
138 if not tests_to_run: 138 if not tests_to_run:
139 _log.critical('No tests to run.') 139 _log.critical('No tests to run.')
140 return test_run_results.RunDetails(exit_code=exit_codes.NO_TESTS_EXI T_STATUS) 140 return test_run_results.RunDetails(exit_code=exit_codes.NO_TESTS_EXI T_STATUS)
141 141
(...skipping 412 matching lines...) Expand 10 before | Expand all | Expand 10 after
554 554
555 stats = {} 555 stats = {}
556 for result in initial_results.results_by_name.values(): 556 for result in initial_results.results_by_name.values():
557 if result.type != test_expectations.SKIP: 557 if result.type != test_expectations.SKIP:
558 stats[result.test_name] = {'results': (_worker_number(result.wor ker_name), result.test_number, result.pid, int( 558 stats[result.test_name] = {'results': (_worker_number(result.wor ker_name), result.test_number, result.pid, int(
559 result.test_run_time * 1000), int(result.total_run_time * 10 00))} 559 result.test_run_time * 1000), int(result.total_run_time * 10 00))}
560 stats_trie = {} 560 stats_trie = {}
561 for name, value in stats.iteritems(): 561 for name, value in stats.iteritems():
562 json_results_generator.add_path_to_trie(name, value, stats_trie) 562 json_results_generator.add_path_to_trie(name, value, stats_trie)
563 return stats_trie 563 return stats_trie
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698