third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py - Issue 2872593004: webkitpy: Fix removing expectation lines.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

Issue 2872593004: webkitpy: Fix removing expectation lines. (Closed)

Patch Set: git cl try Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

index 35ab4247ef8dd3ef74b86ef91b11e6a7d897d4c2..594c9784d564d6144ef8f04009a1818adbc21807 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

@@ -128,7 +128,7 @@ class Manager(object):

tests_to_run, tests_to_skip = self._prepare_lists(paths, test_names)

- self._expectations.remove_tests(tests_in_other_chunks)

+ self._expectations.remove_tests_from_expectations(tests_in_other_chunks)

self._printer.print_found(

len(all_test_names), len(test_names), len(tests_to_run),

« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py » ('j') | no next file with comments »