Use OnceCallback on Mojo interfaces in //device/gamepad

Use OnceCallback on Mojo interfaces in //device/gamepad

This CL flips `use_once_calback` flag on the Mojo code generator, and
fixes all compile errors after it. After this CL, Mojo interfaces in
//device/gamepad starts using base::OnceCallback instead of
base::Callback on its return value handling.

The migration recipe was:
 - Convert pass-by-ref callback objects to pass-by-value.
 - Use std::move() to forward it to other consumer, or to invoke it
   with Callback::Run().
 - Handle wherever copies are required manually.
 - Check if the conversion doesn't change the semantics. As the transfer
   and invocation clobber the callback object, care about use-after-move.
   It's considered safe to consume almost scoped-out callback.

BUG=714018
Review-Url: https://codereview.chromium.org/2872563002
Cr-Commit-Position: refs/heads/master@{#471779}
Committed: https://chromium.googlesource.com/chromium/src/+/d9b1d7c05d1d18606bad0a0ebfb75e7240c4b5e1

[tzik, 2017-05-08 11:31:21]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[tzik, 2017-05-08 11:31:38]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 11:31:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 12:47:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 12:47:01]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tzik, 2017-05-09 09:35:53]

Description was changed from

==========
Use OnceCallback on Mojo interfaces in //device/gamepad
==========

to

==========
Use OnceCallback on Mojo interfaces in //device/gamepad

This CL flips `use_once_calback` flag on the Mojo code generator, and
fixes all compile errors after it. After this CL, Mojo interfaces in
//device/gamepad starts using base::OnceCallback instead of
base::Callback on its return value handling.

The migration recipe was:
 - Convert pass-by-ref callback objects to pass-by-value.
 - Use std::move() to forward it to other consumer, or to invoke it
   with Callback::Run().
 - Handle wherever copies are required manually.
 - Check if the conversion doesn't change the semantics. As the transfer
   and invocation clobber the callback object, care about use-after-move.
   It's considered safe to consume almost scoped-out callback.

BUG=714018
==========

[tzik, 2017-05-09 09:36:14]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 09:36:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-05-09 09:37:24]

Description was changed from

==========
Use OnceCallback on Mojo interfaces in //device/gamepad

This CL flips `use_once_calback` flag on the Mojo code generator, and
fixes all compile errors after it. After this CL, Mojo interfaces in
//device/gamepad starts using base::OnceCallback instead of
base::Callback on its return value handling.

The migration recipe was:
 - Convert pass-by-ref callback objects to pass-by-value.
 - Use std::move() to forward it to other consumer, or to invoke it
   with Callback::Run().
 - Handle wherever copies are required manually.
 - Check if the conversion doesn't change the semantics. As the transfer
   and invocation clobber the callback object, care about use-after-move.
   It's considered safe to consume almost scoped-out callback.

BUG=714018
==========

to

==========
Use OnceCallback on Mojo interfaces in //device/gamepad

This CL flips `use_once_calback` flag on the Mojo code generator, and
fixes all compile errors after it. After this CL, Mojo interfaces in
//device/gamepad starts using base::OnceCallback instead of
base::Callback on its return value handling.

The migration recipe was:
 - Convert pass-by-ref callback objects to pass-by-value.
 - Use std::move() to forward it to other consumer, or to invoke it
   with Callback::Run().
 - Handle wherever copies are required manually.
 - Check if the conversion doesn't change the semantics. As the transfer
   and invocation clobber the callback object, care about use-after-move.
   It's considered safe to consume almost scoped-out callback.

BUG=714018
==========

[tzik, 2017-05-09 09:37:24]

tzik@chromium.org changed reviewers:
+ scottmg@chromium.org

[commit-bot: I haz the power, 2017-05-09 10:45:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 10:45:42]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[tzik, 2017-05-09 11:00:17]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 11:00:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 11:59:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 11:59:45]

Dry run: This issue passed the CQ dry run.

[tzik, 2017-05-11 09:13:10]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 09:13:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-05-11 09:13:55]

PTAL

[commit-bot: I haz the power, 2017-05-11 11:09:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 11:09:45]

Dry run: This issue passed the CQ dry run.

[scottmg, 2017-05-11 15:00:06]

lgtm

[tzik, 2017-05-11 16:12:36]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2017-05-11 16:13:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 16:25:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 16:25:56]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tzik, 2017-05-15 06:12:52]

tzik@chromium.org changed reviewers:
+ dcheng@chromium.org

[tzik, 2017-05-15 06:12:53]

Adding dcheng as a SECURITY_OWNER for gamepad_struct_traits_unittest.cc review.
PTAL.

[dcheng, 2017-05-15 06:15:44]

LGTM

[tzik, 2017-05-15 08:33:48]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2017-05-15 08:34:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 09:51:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 09:51:50]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tzik, 2017-05-15 14:27:20]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2017-05-15 14:27:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 16:13:07]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494858440892210,
"parent_rev": "fee7ccc76fd2955ebc0b949174f283ee8ed41d24", "commit_rev":
"d9b1d7c05d1d18606bad0a0ebfb75e7240c4b5e1"}

[commit-bot: I haz the power, 2017-05-15 16:13:25]

Description was changed from

==========
Use OnceCallback on Mojo interfaces in //device/gamepad

This CL flips `use_once_calback` flag on the Mojo code generator, and
fixes all compile errors after it. After this CL, Mojo interfaces in
//device/gamepad starts using base::OnceCallback instead of
base::Callback on its return value handling.

The migration recipe was:
 - Convert pass-by-ref callback objects to pass-by-value.
 - Use std::move() to forward it to other consumer, or to invoke it
   with Callback::Run().
 - Handle wherever copies are required manually.
 - Check if the conversion doesn't change the semantics. As the transfer
   and invocation clobber the callback object, care about use-after-move.
   It's considered safe to consume almost scoped-out callback.

BUG=714018
==========

to

==========
Use OnceCallback on Mojo interfaces in //device/gamepad

This CL flips `use_once_calback` flag on the Mojo code generator, and
fixes all compile errors after it. After this CL, Mojo interfaces in
//device/gamepad starts using base::OnceCallback instead of
base::Callback on its return value handling.

The migration recipe was:
 - Convert pass-by-ref callback objects to pass-by-value.
 - Use std::move() to forward it to other consumer, or to invoke it
   with Callback::Run().
 - Handle wherever copies are required manually.
 - Check if the conversion doesn't change the semantics. As the transfer
   and invocation clobber the callback object, care about use-after-move.
   It's considered safe to consume almost scoped-out callback.

BUG=714018

Review-Url: https://codereview.chromium.org/2872563002
Cr-Commit-Position: refs/heads/master@{#471779}
Committed:
https://chromium.googlesource.com/chromium/src/+/d9b1d7c05d1d18606bad0a0ebfb7...
==========

[commit-bot: I haz the power, 2017-05-15 16:13:35]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d9b1d7c05d1d18606bad0a0ebfb7...