Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1667)

Unified Diff: device/gamepad/gamepad_monitor.cc

Issue 2872563002: Use OnceCallback on Mojo interfaces in //device/gamepad (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/gamepad/gamepad_monitor.h ('k') | device/gamepad/public/interfaces/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/gamepad/gamepad_monitor.cc
diff --git a/device/gamepad/gamepad_monitor.cc b/device/gamepad/gamepad_monitor.cc
index 0f85717716e38b0fb96f4bc9a08ad5a4668bb88c..7ba2e834915ca9c0fe687b07d1f06479792099f7 100644
--- a/device/gamepad/gamepad_monitor.cc
+++ b/device/gamepad/gamepad_monitor.cc
@@ -4,6 +4,8 @@
#include "device/gamepad/gamepad_monitor.h"
+#include <utility>
+
#include "base/memory/ptr_util.h"
#include "base/memory/shared_memory.h"
#include "device/gamepad/gamepad_service.h"
@@ -38,23 +40,21 @@ void GamepadMonitor::OnGamepadDisconnected(unsigned index,
gamepad_observer_->GamepadDisconnected(index, gamepad);
}
-void GamepadMonitor::GamepadStartPolling(
- const GamepadStartPollingCallback& callback) {
+void GamepadMonitor::GamepadStartPolling(GamepadStartPollingCallback callback) {
DCHECK(!is_started_);
is_started_ = true;
GamepadService* service = GamepadService::GetInstance();
service->ConsumerBecameActive(this);
- callback.Run(service->GetSharedBufferHandle());
+ std::move(callback).Run(service->GetSharedBufferHandle());
}
-void GamepadMonitor::GamepadStopPolling(
- const GamepadStopPollingCallback& callback) {
+void GamepadMonitor::GamepadStopPolling(GamepadStopPollingCallback callback) {
DCHECK(is_started_);
is_started_ = false;
GamepadService::GetInstance()->ConsumerBecameInactive(this);
- callback.Run();
+ std::move(callback).Run();
}
void GamepadMonitor::SetObserver(mojom::GamepadObserverPtr gamepad_observer) {
« no previous file with comments | « device/gamepad/gamepad_monitor.h ('k') | device/gamepad/public/interfaces/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698