third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h - Issue 2871823002: [DMC #5.7] Move DocumentMarkerList::RemoveMarkersUnderWords() to SpellCheckMarkerListImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h

Issue 2871823002: [DMC #5.7] Move DocumentMarkerList::RemoveMarkersUnderWords() to SpellCheckMarkerListImpl (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp ('k') | third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h

diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h

index 4ec0eec6e76d5cd321775f9a7dba92cf94193364..bd3308cdf3054140632fb1c76d2d22ab29738359 100644

--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h

+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerList.h

@@ -40,12 +40,6 @@ class CORE_EXPORT DocumentMarkerList

// Returns true if at least one marker is removed, false otherwise

virtual bool RemoveMarkers(unsigned start_offset, int length) = 0;

- // Returns true if a marker was removed, false otherwise.

- // TODO(rlanday): remove this method from this interface once we have a

- // Spelling/Grammar-specific marker list impl to put this on

- virtual bool RemoveMarkersUnderWords(const String& node_text,

- const Vector<String>& words) = 0;

// Returns true if at least one marker is shifted or removed, false otherwise

virtual bool ShiftMarkers(unsigned offset,

unsigned old_length,