Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 2871653002: Remove raw base::DictionaryValue::SetWithoutPathExpansion in //chromeos (Closed)

Created:
3 years, 7 months ago by jdoerrie
Modified:
3 years, 7 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org, hashimoto+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove raw base::DictionaryValue::SetWithoutPathExpansion in //chromeos This change removes the deprecated raw pointer version of base::DictionaryValue::SetWithoutPathExpansion in //chromeos and replaces it with the unique pointer version or other convenience functions where appropriate. BUG=646113 Review-Url: https://codereview.chromium.org/2871653002 Cr-Commit-Position: refs/heads/master@{#470593} Committed: https://chromium.googlesource.com/chromium/src/+/05f02a7cde35e52f43c38f6b0b3edd422f83a0b9

Patch Set 1 #

Patch Set 2 : Minor Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -132 lines) Patch
M chromeos/dbus/fake_shill_device_client.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M chromeos/dbus/fake_shill_ipconfig_client.cc View 3 chunks +9 lines, -11 lines 0 comments Download
M chromeos/dbus/fake_shill_manager_client.h View 2 chunks +4 lines, -1 line 0 comments Download
M chromeos/dbus/fake_shill_manager_client.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M chromeos/dbus/fake_shill_profile_client.cc View 1 4 chunks +12 lines, -7 lines 0 comments Download
M chromeos/dbus/fake_shill_service_client.cc View 5 chunks +17 lines, -10 lines 0 comments Download
M chromeos/dbus/gsm_sms_client_unittest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chromeos/dbus/shill_client_unittest_base.cc View 2 chunks +9 lines, -10 lines 0 comments Download
M chromeos/dbus/shill_device_client_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/dbus/shill_ipconfig_client_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chromeos/dbus/shill_manager_client_unittest.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M chromeos/dbus/shill_profile_client_unittest.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M chromeos/dbus/shill_service_client_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chromeos/network/device_state.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M chromeos/network/managed_network_configuration_handler_impl.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chromeos/network/managed_network_configuration_handler_unittest.cc View 4 chunks +9 lines, -6 lines 0 comments Download
M chromeos/network/network_configuration_handler_unittest.cc View 3 chunks +6 lines, -9 lines 0 comments Download
M chromeos/network/network_state.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chromeos/network/network_state_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_ui_data.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chromeos/network/network_util.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chromeos/network/onc/onc_mapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/onc/onc_merger.cc View 4 chunks +11 lines, -8 lines 0 comments Download
M chromeos/network/onc/onc_translator_onc_to_shill.cc View 4 chunks +11 lines, -10 lines 0 comments Download
M chromeos/network/onc/onc_utils.cc View 6 chunks +6 lines, -5 lines 0 comments Download
M chromeos/network/policy_util.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
jdoerrie
vabr@chromium.org: Please review the whole CL in detail. stevenjb@chromium.org: Please spot-check and rubber-stamp.
3 years, 7 months ago (2017-05-09 22:48:47 UTC) #11
stevenjb
lgtm
3 years, 7 months ago (2017-05-09 23:16:38 UTC) #12
vabr (Chromium)
LGTM, nice! Vaclav
3 years, 7 months ago (2017-05-10 09:36:32 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871653002/20001
3 years, 7 months ago (2017-05-10 15:09:37 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 16:11:18 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/05f02a7cde35e52f43c38f6b0b3e...

Powered by Google App Engine
This is Rietveld 408576698