Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1285)

Unified Diff: chromeos/network/network_state.cc

Issue 2871653002: Remove raw base::DictionaryValue::SetWithoutPathExpansion in //chromeos (Closed)
Patch Set: Minor Fix Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/network_state.cc
diff --git a/chromeos/network/network_state.cc b/chromeos/network/network_state.cc
index 55775188273c64302a5c7be17255a5747ea5ce2e..dff74c4c3968a324842b1ae2bc6d4f602afa471c 100644
--- a/chromeos/network/network_state.cc
+++ b/chromeos/network/network_state.cc
@@ -7,9 +7,11 @@
#include <stddef.h>
#include <memory>
+#include <utility>
#include "base/strings/string_number_conversions.h"
#include "base/strings/stringprintf.h"
+#include "base/values.h"
#include "chromeos/network/network_profile_handler.h"
#include "chromeos/network/network_type_pattern.h"
#include "chromeos/network/network_util.h"
@@ -259,7 +261,7 @@ void NetworkState::GetStateProperties(base::DictionaryValue* dictionary) const {
shill::kHostProperty, third_party_vpn_provider_extension_id_);
}
dictionary->SetWithoutPathExpansion(shill::kProviderProperty,
- provider_property.release());
+ std::move(provider_property));
}
// Tether properties
« no previous file with comments | « chromeos/network/network_configuration_handler_unittest.cc ('k') | chromeos/network/network_state_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698