Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2944)

Unified Diff: chromeos/network/network_configuration_handler_unittest.cc

Issue 2871653002: Remove raw base::DictionaryValue::SetWithoutPathExpansion in //chromeos (Closed)
Patch Set: Minor Fix Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/network_configuration_handler_unittest.cc
diff --git a/chromeos/network/network_configuration_handler_unittest.cc b/chromeos/network/network_configuration_handler_unittest.cc
index eb5b6ea2401f8ce88a3a7751c93bc54ae9d68d93..976da8ee06580130ebd65743421fea35b8be2a97 100644
--- a/chromeos/network/network_configuration_handler_unittest.cc
+++ b/chromeos/network/network_configuration_handler_unittest.cc
@@ -484,9 +484,8 @@ TEST_F(NetworkConfigurationHandlerTest, CreateConfiguration) {
std::string profile = "profile path";
base::DictionaryValue value;
shill_property_util::SetSSID(networkName, &value);
- value.SetWithoutPathExpansion(shill::kTypeProperty, new base::Value(type));
- value.SetWithoutPathExpansion(shill::kProfileProperty,
- new base::Value(profile));
+ value.SetStringWithoutPathExpansion(shill::kTypeProperty, type);
+ value.SetStringWithoutPathExpansion(shill::kProfileProperty, profile);
EXPECT_CALL(*mock_manager_client_,
ConfigureServiceForProfile(dbus::ObjectPath(profile), _, _, _))
@@ -505,9 +504,8 @@ TEST_F(NetworkConfigurationHandlerTest, RemoveConfiguration) {
std::string type = "wifi";
base::DictionaryValue value;
shill_property_util::SetSSID("Service", &value);
- value.SetWithoutPathExpansion(shill::kTypeProperty, new base::Value(type));
- value.SetWithoutPathExpansion(shill::kProfileProperty,
- new base::Value("profile2"));
+ value.SetStringWithoutPathExpansion(shill::kTypeProperty, type);
+ value.SetStringWithoutPathExpansion(shill::kProfileProperty, "profile2");
EXPECT_CALL(*mock_manager_client_,
ConfigureServiceForProfile(dbus::ObjectPath("profile2"), _, _, _))
.WillOnce(
@@ -556,9 +554,8 @@ TEST_F(NetworkConfigurationHandlerTest, RemoveConfigurationFromCurrentProfile) {
std::string type = "wifi";
base::DictionaryValue value;
shill_property_util::SetSSID("Service", &value);
- value.SetWithoutPathExpansion(shill::kTypeProperty, new base::Value(type));
- value.SetWithoutPathExpansion(shill::kProfileProperty,
- new base::Value("profile2"));
+ value.SetStringWithoutPathExpansion(shill::kTypeProperty, type);
+ value.SetStringWithoutPathExpansion(shill::kProfileProperty, "profile2");
EXPECT_CALL(*mock_manager_client_,
ConfigureServiceForProfile(dbus::ObjectPath("profile2"), _, _, _))
.WillOnce(
« no previous file with comments | « chromeos/network/managed_network_configuration_handler_unittest.cc ('k') | chromeos/network/network_state.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698