Chromium Code Reviews
DescriptionMD Settings: Network: Do not call setProperties when setting defaults
In https://codereview.chromium.org/2665913002 we set some default
network properties in currentRouteChanged. This was triggering
networkPropertiesChanged_ which udates autoConnect_ and
preferNetwork_ which triggers calls to setNetworkProperties.
To prevent this sort of error, set networkPropertiesReceived_
once properties are received from Chrome and do not call
networkingPrivate.setProperties until that has been set.
BUG=718389
Review-Url: https://codereview.chromium.org/2863713004
Cr-Commit-Position: refs/heads/master@{#469523}
(cherry picked from commit b59f96b265d0bfb15ee56647ab4e3e28ae886b38)
Review-Url: https://codereview.chromium.org/2871523003 .
Cr-Commit-Position: refs/branch-heads/3071@{#447}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed: https://chromium.googlesource.com/chromium/src/+/c5bf61790cc99348dd4589cfc032c8a0133d3d50
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
|||||||||||||||||||