MD Settings: Network: Do not call setProperties when setting defaults

MD Settings: Network: Do not call setProperties when setting defaults

In https://codereview.chromium.org/2665913002 we set some default
network properties in currentRouteChanged. This was triggering
networkPropertiesChanged_ which udates autoConnect_ and
preferNetwork_ which triggers calls to setNetworkProperties.

To prevent this sort of error, set networkPropertiesReceived_
once properties are received from Chrome and do not call
networkingPrivate.setProperties until that has been set.

BUG=718389
Review-Url: https://codereview.chromium.org/2863713004
Cr-Commit-Position: refs/heads/master@{#469523}
Committed: https://chromium.googlesource.com/chromium/src/+/b59f96b265d0bfb15ee56647ab4e3e28ae886b38

[stevenjb, 2017-05-04 21:20:24]

Description was changed from

==========
MD Settings: Network: Do not call setProperties when setting defaults

In https://codereview.chromium.org/2665913002 we set some default
network properties in currentRouteChanged. This was triggering
networkPropertiesChanged_ which udates autoConnect_ and
preferNetwork_ which triggers calls to setNetworkProperties.

To prevent this sort of error, set networkPropertiesReceived_
once properties are received from Chrome and do not call
networkingPrivate.setProperties until that has been set.

BUG=718389
==========

to

==========
MD Settings: Network: Do not call setProperties when setting defaults

In https://codereview.chromium.org/2665913002 we set some default
network properties in currentRouteChanged. This was triggering
networkPropertiesChanged_ which udates autoConnect_ and
preferNetwork_ which triggers calls to setNetworkProperties.

To prevent this sort of error, set networkPropertiesReceived_
once properties are received from Chrome and do not call
networkingPrivate.setProperties until that has been set.

BUG=718389
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-05-04 21:21:50]

stevenjb@chromium.org changed reviewers:
+ michaelpg@chromium.org

[michaelpg, 2017-05-04 22:25:07]

lgtm - I see how this fixes the issue. But separately, (how much) do we call
networkingPrivate.setProperties with unchanged properties? I guess I'm worried
about a risk of feedback loop.

[stevenjb, 2017-05-04 22:28:10]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-05-04 22:28:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stevenjb, 2017-05-04 22:31:12]

On 2017/05/04 22:25:07, michaelpg wrote:
> lgtm - I see how this fixes the issue. But separately, (how much) do we call
> networkingPrivate.setProperties with unchanged properties? I guess I'm worried
> about a risk of feedback loop.

There are currently only two places where we call
networkingPrivate.setProperties, here and in the known networks page, where we
only call it in response to a tap event.

I am currently working on the configuration UI where I will be sure to put in
similar protections.

[commit-bot: I haz the power, 2017-05-04 23:39:18]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493936890221630, "parent_rev":
"06014b12cb233379169758b863703053d99cacc3", "commit_rev":
"b59f96b265d0bfb15ee56647ab4e3e28ae886b38"}

[commit-bot: I haz the power, 2017-05-04 23:39:28]

Description was changed from

==========
MD Settings: Network: Do not call setProperties when setting defaults

In https://codereview.chromium.org/2665913002 we set some default
network properties in currentRouteChanged. This was triggering
networkPropertiesChanged_ which udates autoConnect_ and
preferNetwork_ which triggers calls to setNetworkProperties.

To prevent this sort of error, set networkPropertiesReceived_
once properties are received from Chrome and do not call
networkingPrivate.setProperties until that has been set.

BUG=718389
==========

to

==========
MD Settings: Network: Do not call setProperties when setting defaults

In https://codereview.chromium.org/2665913002 we set some default
network properties in currentRouteChanged. This was triggering
networkPropertiesChanged_ which udates autoConnect_ and
preferNetwork_ which triggers calls to setNetworkProperties.

To prevent this sort of error, set networkPropertiesReceived_
once properties are received from Chrome and do not call
networkingPrivate.setProperties until that has been set.

BUG=718389

Review-Url: https://codereview.chromium.org/2863713004
Cr-Commit-Position: refs/heads/master@{#469523}
Committed:
https://chromium.googlesource.com/chromium/src/+/b59f96b265d0bfb15ee56647ab4e...
==========

[commit-bot: I haz the power, 2017-05-04 23:39:29]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b59f96b265d0bfb15ee56647ab4e...