MD Settings: Internet: Make detail page layout more robust

MD Settings: Internet: Make detail page layout more robust

This passes state info to the details page (when we know it) so that the initial layout will more closely resemble the final layout.

BUG=682161
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2665913002
Cr-Commit-Position: refs/heads/master@{#447419}
Committed: https://chromium.googlesource.com/chromium/src/+/531c430cd5f09d9723b17e649eaa481a02a7319c

[stevenjb, 2017-01-30 22:23:58]

Description was changed from

==========
MD Settings: Internet: Make detail page layout more robust

BUG=682161
==========

to

==========
MD Settings: Internet: Make detail page layout more robust

BUG=682161
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-01-30 22:26:19]

Description was changed from

==========
MD Settings: Internet: Make detail page layout more robust

BUG=682161
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Internet: Make detail page layout more robust

This passes state info to the details page (when we know it) so that the initial
layout will more closely resemble the final layout.

BUG=682161
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-01-30 22:26:28]

stevenjb@chromium.org changed reviewers:
+ michaelpg@chromium.org

[michaelpg, 2017-01-31 21:47:47]

https://codereview.chromium.org/2665913002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/internet_page/internet_detail_page.js
(right):

https://codereview.chromium.org/2665913002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/internet_detail_page.js:166: //
Set basic networkProperties until the are loaded.
the => they

https://codereview.chromium.org/2665913002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/internet_detail_page.js:174:
Name: {Active: queryParams.get('name') || type},
nit: var name = ... (as above)

the... dependency chain of these properties requires too much effort to follow.

https://codereview.chromium.org/2665913002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/internet_detail_page.js:743: if
(type == CrOnc.Type.CELLULAR && !!this.networkProperties.Cellular) {
maybe put this logic in a helper function, e.g. isNetworkType?

https://codereview.chromium.org/2665913002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/internet_page/internet_page.js (right):

https://codereview.chromium.org/2665913002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/internet_page.js:123: 'guid=' +
event.detail.GUID + '&type=' + event.detail.Type +
would prefer not to build this manually, see URLSearchParams#append() and
#toString()

[stevenjb, 2017-01-31 22:23:55]

https://codereview.chromium.org/2665913002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/internet_page/internet_detail_page.js
(right):

https://codereview.chromium.org/2665913002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/internet_detail_page.js:166: //
Set basic networkProperties until the are loaded.
On 2017/01/31 21:47:46, michaelpg wrote:
> the => they

Done.

https://codereview.chromium.org/2665913002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/internet_detail_page.js:174:
Name: {Active: queryParams.get('name') || type},
On 2017/01/31 21:47:46, michaelpg wrote:
> nit: var name = ... (as above)
> 
> the... dependency chain of these properties requires too much effort to
follow.

Done.

https://codereview.chromium.org/2665913002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/internet_detail_page.js:743: if
(type == CrOnc.Type.CELLULAR && !!this.networkProperties.Cellular) {
On 2017/01/31 21:47:46, michaelpg wrote:
> maybe put this logic in a helper function, e.g. isNetworkType?

Well, I have a helper, but we've already extracted type so this is more
efficient.

https://codereview.chromium.org/2665913002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/internet_page/internet_page.js (right):

https://codereview.chromium.org/2665913002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/internet_page.js:123: 'guid=' +
event.detail.GUID + '&type=' + event.detail.Type +
On 2017/01/31 21:47:47, michaelpg wrote:
> would prefer not to build this manually, see URLSearchParams#append() and
> #toString()

Huh, I didn't notice examples of that when I looked (and didn't realize it was a
builtin). Done.

[michaelpg, 2017-02-01 00:39:29]

lgtm

[stevenjb, 2017-02-01 00:55:06]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-02-01 00:55:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 02:30:30]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485910506516170,
"parent_rev": "702cf1e3d35edc439556037b299bf6561a18c904", "commit_rev":
"531c430cd5f09d9723b17e649eaa481a02a7319c"}

[commit-bot: I haz the power, 2017-02-01 02:31:05]

Description was changed from

==========
MD Settings: Internet: Make detail page layout more robust

This passes state info to the details page (when we know it) so that the initial
layout will more closely resemble the final layout.

BUG=682161
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Internet: Make detail page layout more robust

This passes state info to the details page (when we know it) so that the initial
layout will more closely resemble the final layout.

BUG=682161
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2665913002
Cr-Commit-Position: refs/heads/master@{#447419}
Committed:
https://chromium.googlesource.com/chromium/src/+/531c430cd5f09d9723b17e649eaa...
==========

[commit-bot: I haz the power, 2017-02-01 02:31:09]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/531c430cd5f09d9723b17e649eaa...