Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Issue 2871063002: [relanding] Adding BrowsingInstance verification to test of chrome.windows.create API. (Closed)

Created:
3 years, 7 months ago by Łukasz Anforowicz
Modified:
3 years, 7 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[relanding] Adding BrowsingInstance verification to test of chrome.windows.create API. BUG=597750 Review-Url: https://codereview.chromium.org/2871063002 Cr-Commit-Position: refs/heads/master@{#470627} Committed: https://chromium.googlesource.com/chromium/src/+/41d0368bc22967ae30b2b5097d887f6552efff83

Patch Set 1 : Copy of what landed in https://codereview.chromium.org/2873693003/ #

Patch Set 2 : Wait for |new_contents| to stop loading before next test steps. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M chrome/browser/extensions/api/tabs/tabs_test.cc View 1 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Łukasz Anforowicz
lazyboy@, could you PTAL? This is a reland of https://codereview.chromium.org/2873693003 that you've looked at yesterday. ...
3 years, 7 months ago (2017-05-10 17:05:59 UTC) #6
lazyboy
lgtm
3 years, 7 months ago (2017-05-10 17:09:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2871063002/20001
3 years, 7 months ago (2017-05-10 17:12:59 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 17:20:19 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/41d0368bc22967ae30b2b5097d88...

Powered by Google App Engine
This is Rietveld 408576698