Adding BrowsingInstance verification to test of chrome.windows.create API.

Adding BrowsingInstance verification to test of chrome.windows.create API.

BUG=597750
Review-Url: https://codereview.chromium.org/2873693003
Cr-Commit-Position: refs/heads/master@{#470409}
Committed: https://chromium.googlesource.com/chromium/src/+/35b5da108fd0ae4c66c7665a09d0a3d682ce25e5

[Łukasz Anforowicz, 2017-05-09 16:34:46]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 16:35:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2017-05-09 16:39:21]

lukasza@chromium.org changed reviewers:
+ lazyboy@chromium.org

[Łukasz Anforowicz, 2017-05-09 16:39:22]

lazyboy@, could you PTAL?

Notes:

- The new test verification covers functionality that the hangouts extension
depends on.

- I should have added the extra test in
https://codereview.chromium.org/2686943002.

- I am adding the test now, because I've realized today that my work on
https://crbug.com/718489 is related (e.g. WIP CL @
https://codereview.chromium.org/2873503002 regresses the test verification I am
adding in the current CL).

[lazyboy, 2017-05-09 17:04:00]

lgtm, thanks for the helpful notes.

[Łukasz Anforowicz, 2017-05-09 17:07:05]

The CQ bit was unchecked by lukasza@chromium.org

[Łukasz Anforowicz, 2017-05-09 17:07:08]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2017-05-09 17:08:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 19:36:18]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494349628754870, "parent_rev":
"dfef613f078ed5cddcff6ff82037aac8f0473036", "commit_rev":
"35b5da108fd0ae4c66c7665a09d0a3d682ce25e5"}

[commit-bot: I haz the power, 2017-05-09 19:36:31]

Description was changed from

==========
Adding BrowsingInstance verification to test of chrome.windows.create API.

BUG=597750
==========

to

==========
Adding BrowsingInstance verification to test of chrome.windows.create API.

BUG=597750

Review-Url: https://codereview.chromium.org/2873693003
Cr-Commit-Position: refs/heads/master@{#470409}
Committed:
https://chromium.googlesource.com/chromium/src/+/35b5da108fd0ae4c66c7665a09d0...
==========

[commit-bot: I haz the power, 2017-05-09 19:36:32]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/35b5da108fd0ae4c66c7665a09d0...

[chanli1, 2017-05-09 22:52:59]

On 2017/05/09 19:36:32, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/35b5da108fd0ae4c66c7665a09d0...

Hi,

ExtensionApiTest.WindowsCreateVsSiteInstance failed on
https://luci-milo.appspot.com/buildbot/chromium.linux/Linux%20Tests/56238 and
https://luci-milo.appspot.com/buildbot/chromium.mac/Mac10.11%20Tests/12151

Findit has identified the test is flaky
(https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWV...)
since earlier builds which leads me to this CL.

Could you help me confirm does this change make the test flaky?

Thanks,
Chan Li

[Łukasz Anforowicz, 2017-05-09 23:02:31]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2870243002/ by lukasza@chromium.org.

The reason for reverting is: The modified test became flaky..