[relanding] Adding BrowsingInstance verification to test of chrome.windows.create API.

chrome/browser/extensions/api/tabs/tabs_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <limits.h>
 #include <stddef.h>
 #include <stdint.h>
 
 #include <memory>
 #include <string>
@@ skipping 2146 matching lines @@
   GURL extension_url = extension->GetResourceURL("file.html");
   ui_test_utils::NavigateToURL(browser(), extension_url);
   content::WebContents* old_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
 
   // Execute chrome.windows.create and store the new tab in |new_contents|.
   content::WebContents* new_contents = nullptr;
   {
     content::WebContentsAddedObserver observer;
     ASSERT_TRUE(content::ExecuteScript(old_contents,
-                                       "window.name = 'test-name';\n"
+                                       "window.name = 'old-contents';\n"
                                        "chrome.windows.create({url: '" +
                                            extension_url.spec() + "'})"));
     new_contents = observer.GetWebContents();
+    ASSERT_TRUE(content::WaitForLoadStop(new_contents));
   }
 
   // Verify that the old and new tab are in the same process and SiteInstance.
   // Note: both test assertions are important - one observed failure mode was
   // having the same process, but different SiteInstance.
   EXPECT_EQ(old_contents->GetMainFrame()->GetProcess(),
             new_contents->GetMainFrame()->GetProcess());
   EXPECT_EQ(old_contents->GetMainFrame()->GetSiteInstance(),
             new_contents->GetMainFrame()->GetSiteInstance());
 
   // Verify that the |new_contents| doesn't have a |window.opener| set.
   bool window_opener_cast_to_bool = true;
   EXPECT_TRUE(ExecuteScriptAndExtractBool(
       new_contents, "window.domAutomationController.send(!!window.opener)",
       &window_opener_cast_to_bool));
   EXPECT_FALSE(window_opener_cast_to_bool);
+
+  // Verify that |new_contents| can find |old_contents| using window.open/name.
+  std::string location_of_other_window;
+  EXPECT_TRUE(ExecuteScriptAndExtractString(
+      new_contents,
+      "var w = window.open('', 'old-contents');\n"
+      "window.domAutomationController.send(w.location.href);",
+      &location_of_other_window));
+  EXPECT_EQ(old_contents->GetMainFrame()->GetLastCommittedURL().spec(),
+            location_of_other_window);
 }
 
 }  // namespace extensions