Rename IDBRequest::On* callbacks to IDBRequest::Enqueue*.

Rename IDBRequest::On* callbacks to IDBRequest::Enqueue*.

The current OnSuccess() / OnError() naming scheme is a bit misleading,
because it suggests that the success and error events are dispatched to
script synchronously. The events are actually queued up, via
ExecutionContext::EnqueueEvent(), in order to support having the
application be suspended in Dev Tools.

This CL fixes up the naming scheme and de-virtualizes some IDBRequest
methods that are not overridden by its only subclass, IDBOpenDBRequest.
This leads the way to more complex changes in event processing needed by
the referenced bug.

BUG=713409
Review-Url: https://codereview.chromium.org/2870803002
Cr-Commit-Position: refs/heads/master@{#470844}
Committed: https://chromium.googlesource.com/chromium/src/+/55ad6749e01eb6bb63b6fb2f64655a82cf4e7d2c

[pwnall, 2017-05-09 01:29:49]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 01:30:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pwnall, 2017-05-09 01:33:31]

pwnall@chromium.org changed reviewers:
+ cmumford@chromium.org, dmurph@chromium.org, jsbell@chromium.org

[pwnall, 2017-05-09 01:33:32]

dmurph: PTAL? What do you think of the new names?

jsbell: I came up with EnqueueResponse instead of EnqueueResult soon after we
chatted, so I couldn't run it by you in person. What do you think? My motivation
is 1) Request/Response, and 2) this avoids confusion with result_, which cannot
change because it's in the IDB spec.

cmumford: Adding you because you've been the long-term maintainer of this code.
Please let me know if you'd rather not deal with IDB reviews for a while.

[pwnall, 2017-05-09 01:50:43]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 01:51:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 04:00:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 04:00:39]

Dry run: This issue passed the CQ dry run.

[jsbell, 2017-05-09 16:27:41]

On 2017/05/09 01:33:32, pwnall wrote:
> jsbell: I came up with EnqueueResponse instead of EnqueueResult soon after we
> chatted, so I couldn't run it by you in person. What do you think? My
motivation
> is 1) Request/Response, and 2) this avoids confusion with result_, which
cannot
> change because it's in the IDB spec.

sgtm

[dmurph, 2017-05-09 20:18:43]

lgtm

[cmumford, 2017-05-09 22:19:50]

lgtm

[pwnall, 2017-05-09 22:43:26]

On 2017/05/09 22:19:50, cmumford wrote:
> lgtm

jsbell, dmurph, cmumford: Thank you very much for the quick response!

[pwnall, 2017-05-09 22:43:31]

The CQ bit was checked by pwnall@chromium.org

[commit-bot: I haz the power, 2017-05-09 22:44:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 00:47:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 00:47:26]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[pwnall, 2017-05-10 01:56:58]

The CQ bit was checked by pwnall@chromium.org

[commit-bot: I haz the power, 2017-05-10 01:57:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 04:00:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 04:00:34]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet;
builder either lacks capacity or does not exist (misspelled?))
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[pwnall, 2017-05-10 08:53:20]

The CQ bit was checked by pwnall@chromium.org

[commit-bot: I haz the power, 2017-05-10 08:53:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 11:32:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 11:32:48]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jsbell, 2017-05-10 15:44:30]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2017-05-10 15:45:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 17:53:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 17:53:54]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jsbell, 2017-05-10 20:33:53]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2017-05-10 20:34:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 22:50:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 22:50:40]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jsbell, 2017-05-10 23:29:59]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2017-05-10 23:32:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pwnall, 2017-05-10 23:33:55]

The CQ bit was checked by pwnall@chromium.org

[commit-bot: I haz the power, 2017-05-10 23:34:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 02:27:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 02:27:49]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pwnall, 2017-05-11 04:20:46]

The CQ bit was checked by pwnall@chromium.org

[commit-bot: I haz the power, 2017-05-11 04:22:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 06:34:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494476446939280,
"parent_rev": "85394da73e559e58395471cb780eee7cb7e3cd49", "commit_rev":
"55ad6749e01eb6bb63b6fb2f64655a82cf4e7d2c"}

[commit-bot: I haz the power, 2017-05-11 06:34:14]

Description was changed from

==========
Rename IDBRequest::On* callbacks to IDBRequest::Enqueue*.

The current OnSuccess() / OnError() naming scheme is a bit misleading,
because it suggests that the success and error events are dispatched to
script synchronously. The events are actually queued up, via
ExecutionContext::EnqueueEvent(), in order to support having the
application be suspended in Dev Tools.

This CL fixes up the naming scheme and de-virtualizes some IDBRequest
methods that are not overridden by its only subclass, IDBOpenDBRequest.
This leads the way to more complex changes in event processing needed by
the referenced bug.

BUG=713409
==========

to

==========
Rename IDBRequest::On* callbacks to IDBRequest::Enqueue*.

The current OnSuccess() / OnError() naming scheme is a bit misleading,
because it suggests that the success and error events are dispatched to
script synchronously. The events are actually queued up, via
ExecutionContext::EnqueueEvent(), in order to support having the
application be suspended in Dev Tools.

This CL fixes up the naming scheme and de-virtualizes some IDBRequest
methods that are not overridden by its only subclass, IDBOpenDBRequest.
This leads the way to more complex changes in event processing needed by
the referenced bug.

BUG=713409

Review-Url: https://codereview.chromium.org/2870803002
Cr-Commit-Position: refs/heads/master@{#470844}
Committed:
https://chromium.googlesource.com/chromium/src/+/55ad6749e01eb6bb63b6fb2f6465...
==========

[commit-bot: I haz the power, 2017-05-11 06:34:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/55ad6749e01eb6bb63b6fb2f6465...