Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBRequest.h

Issue 2870803002: Rename IDBRequest::On* callbacks to IDBRequest::Enqueue*. (Closed)
Patch Set: De-virtualized one more callback. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/indexeddb/IDBRequest.h
diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBRequest.h b/third_party/WebKit/Source/modules/indexeddb/IDBRequest.h
index 7a52cdae05087f05406296abce6fbc3a34a07261..9f271b74ea499cc7318d796a7b5fdf5c67f007cd 100644
--- a/third_party/WebKit/Source/modules/indexeddb/IDBRequest.h
+++ b/third_party/WebKit/Source/modules/indexeddb/IDBRequest.h
@@ -98,30 +98,35 @@ class MODULES_EXPORT IDBRequest : public EventTargetWithInlineData,
void SetPendingCursor(IDBCursor*);
void Abort();
- virtual void OnError(DOMException*);
- virtual void OnSuccess(const Vector<String>&);
- virtual void OnSuccess(std::unique_ptr<WebIDBCursor>,
- IDBKey*,
- IDBKey* primary_key,
- PassRefPtr<IDBValue>);
- virtual void OnSuccess(IDBKey*);
- virtual void OnSuccess(PassRefPtr<IDBValue>);
- virtual void OnSuccess(const Vector<RefPtr<IDBValue>>&);
- virtual void OnSuccess(int64_t);
- virtual void OnSuccess();
- virtual void OnSuccess(IDBKey*, IDBKey* primary_key, PassRefPtr<IDBValue>);
+ void EnqueueResponse(DOMException*);
+ void EnqueueResponse(std::unique_ptr<WebIDBCursor>,
+ IDBKey*,
+ IDBKey* primary_key,
+ PassRefPtr<IDBValue>);
+ void EnqueueResponse(IDBKey*);
+ void EnqueueResponse(PassRefPtr<IDBValue>);
+ void EnqueueResponse(const Vector<RefPtr<IDBValue>>&);
+ void EnqueueResponse();
+ void EnqueueResponse(IDBKey*, IDBKey* primary_key, PassRefPtr<IDBValue>);
+
+ // Only used in webkitGetDatabaseNames(), which is deprecated and hopefully
+ // going away soon.
+ void EnqueueResponse(const Vector<String>&);
+
+ // Overridden by IDBOpenDBRequest.
+ virtual void EnqueueResponse(int64_t);
// Only IDBOpenDBRequest instances should receive these:
- virtual void OnBlocked(int64_t old_version) { NOTREACHED(); }
- virtual void OnUpgradeNeeded(int64_t old_version,
- std::unique_ptr<WebIDBDatabase>,
- const IDBDatabaseMetadata&,
- WebIDBDataLoss,
- String data_loss_message) {
+ virtual void EnqueueBlocked(int64_t old_version) { NOTREACHED(); }
+ virtual void EnqueueUpgradeNeeded(int64_t old_version,
+ std::unique_ptr<WebIDBDatabase>,
+ const IDBDatabaseMetadata&,
+ WebIDBDataLoss,
+ String data_loss_message) {
NOTREACHED();
}
- virtual void OnSuccess(std::unique_ptr<WebIDBDatabase>,
- const IDBDatabaseMetadata&) {
+ virtual void EnqueueResponse(std::unique_ptr<WebIDBDatabase>,
+ const IDBDatabaseMetadata&) {
NOTREACHED();
}
@@ -153,7 +158,7 @@ class MODULES_EXPORT IDBRequest : public EventTargetWithInlineData,
void EnqueueEvent(Event*);
void DequeueEvent(Event*);
virtual bool ShouldEnqueueEvent() const;
- void OnSuccessInternal(IDBAny*);
+ void EnqueueResultInternal(IDBAny*);
void SetResult(IDBAny*);
// EventTarget

Powered by Google App Engine
This is Rietveld 408576698