Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(851)

Unified Diff: third_party/WebKit/Source/modules/indexeddb/WebIDBCallbacksImpl.cpp

Issue 2870803002: Rename IDBRequest::On* callbacks to IDBRequest::Enqueue*. (Closed)
Patch Set: De-virtualized one more callback. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/indexeddb/IDBRequestTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/indexeddb/WebIDBCallbacksImpl.cpp
diff --git a/third_party/WebKit/Source/modules/indexeddb/WebIDBCallbacksImpl.cpp b/third_party/WebKit/Source/modules/indexeddb/WebIDBCallbacksImpl.cpp
index 2f7f7df7a69c68efc6b1941849c1c97745086bfd..3b475585a73a4a5f235d7465dca1624352b2292e 100644
--- a/third_party/WebKit/Source/modules/indexeddb/WebIDBCallbacksImpl.cpp
+++ b/third_party/WebKit/Source/modules/indexeddb/WebIDBCallbacksImpl.cpp
@@ -78,7 +78,8 @@ void WebIDBCallbacksImpl::OnError(const WebIDBDatabaseError& error) {
return;
probe::AsyncTask async_task(request_->GetExecutionContext(), this, "error");
- request_->OnError(DOMException::Create(error.Code(), error.Message()));
+ request_->EnqueueResponse(
+ DOMException::Create(error.Code(), error.Message()));
}
void WebIDBCallbacksImpl::OnSuccess(
@@ -90,7 +91,7 @@ void WebIDBCallbacksImpl::OnSuccess(
for (size_t i = 0; i < web_string_list.size(); ++i)
string_list.push_back(web_string_list[i]);
probe::AsyncTask async_task(request_->GetExecutionContext(), this, "success");
- request_->OnSuccess(string_list);
+ request_->EnqueueResponse(string_list);
}
void WebIDBCallbacksImpl::OnSuccess(WebIDBCursor* cursor,
@@ -101,8 +102,8 @@ void WebIDBCallbacksImpl::OnSuccess(WebIDBCursor* cursor,
return;
probe::AsyncTask async_task(request_->GetExecutionContext(), this, "success");
- request_->OnSuccess(WTF::WrapUnique(cursor), key, primary_key,
- IDBValue::Create(value, request_->GetIsolate()));
+ request_->EnqueueResponse(WTF::WrapUnique(cursor), key, primary_key,
+ IDBValue::Create(value, request_->GetIsolate()));
}
void WebIDBCallbacksImpl::OnSuccess(WebIDBDatabase* backend,
@@ -111,7 +112,7 @@ void WebIDBCallbacksImpl::OnSuccess(WebIDBDatabase* backend,
if (request_) {
probe::AsyncTask async_task(request_->GetExecutionContext(), this,
"success");
- request_->OnSuccess(std::move(db), IDBDatabaseMetadata(metadata));
+ request_->EnqueueResponse(std::move(db), IDBDatabaseMetadata(metadata));
} else if (db) {
db->Close();
}
@@ -122,7 +123,7 @@ void WebIDBCallbacksImpl::OnSuccess(const WebIDBKey& key) {
return;
probe::AsyncTask async_task(request_->GetExecutionContext(), this, "success");
- request_->OnSuccess(key);
+ request_->EnqueueResponse(key);
}
void WebIDBCallbacksImpl::OnSuccess(const WebIDBValue& value) {
@@ -130,7 +131,7 @@ void WebIDBCallbacksImpl::OnSuccess(const WebIDBValue& value) {
return;
probe::AsyncTask async_task(request_->GetExecutionContext(), this, "success");
- request_->OnSuccess(IDBValue::Create(value, request_->GetIsolate()));
+ request_->EnqueueResponse(IDBValue::Create(value, request_->GetIsolate()));
}
void WebIDBCallbacksImpl::OnSuccess(const WebVector<WebIDBValue>& values) {
@@ -141,7 +142,7 @@ void WebIDBCallbacksImpl::OnSuccess(const WebVector<WebIDBValue>& values) {
Vector<RefPtr<IDBValue>> idb_values(values.size());
for (size_t i = 0; i < values.size(); ++i)
idb_values[i] = IDBValue::Create(values[i], request_->GetIsolate());
- request_->OnSuccess(idb_values);
+ request_->EnqueueResponse(idb_values);
}
void WebIDBCallbacksImpl::OnSuccess(long long value) {
@@ -149,7 +150,7 @@ void WebIDBCallbacksImpl::OnSuccess(long long value) {
return;
probe::AsyncTask async_task(request_->GetExecutionContext(), this, "success");
- request_->OnSuccess(value);
+ request_->EnqueueResponse(value);
}
void WebIDBCallbacksImpl::OnSuccess() {
@@ -157,7 +158,7 @@ void WebIDBCallbacksImpl::OnSuccess() {
return;
probe::AsyncTask async_task(request_->GetExecutionContext(), this, "success");
- request_->OnSuccess();
+ request_->EnqueueResponse();
}
void WebIDBCallbacksImpl::OnSuccess(const WebIDBKey& key,
@@ -167,8 +168,8 @@ void WebIDBCallbacksImpl::OnSuccess(const WebIDBKey& key,
return;
probe::AsyncTask async_task(request_->GetExecutionContext(), this, "success");
- request_->OnSuccess(key, primary_key,
- IDBValue::Create(value, request_->GetIsolate()));
+ request_->EnqueueResponse(key, primary_key,
+ IDBValue::Create(value, request_->GetIsolate()));
}
void WebIDBCallbacksImpl::OnBlocked(long long old_version) {
@@ -176,7 +177,7 @@ void WebIDBCallbacksImpl::OnBlocked(long long old_version) {
return;
probe::AsyncTask async_task(request_->GetExecutionContext(), this, "blocked");
- request_->OnBlocked(old_version);
+ request_->EnqueueBlocked(old_version);
}
void WebIDBCallbacksImpl::OnUpgradeNeeded(long long old_version,
@@ -188,7 +189,7 @@ void WebIDBCallbacksImpl::OnUpgradeNeeded(long long old_version,
if (request_) {
probe::AsyncTask async_task(request_->GetExecutionContext(), this,
"upgradeNeeded");
- request_->OnUpgradeNeeded(
+ request_->EnqueueUpgradeNeeded(
old_version, std::move(db), IDBDatabaseMetadata(metadata),
static_cast<WebIDBDataLoss>(data_loss), data_loss_message);
} else {
« no previous file with comments | « third_party/WebKit/Source/modules/indexeddb/IDBRequestTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698