Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: tools/binary_size/libsupersize/linker_map_parser.py

Issue 2870743003: supersize: Add symbol.template_name, and strip <>s from symbol.name (Closed)
Patch Set: review comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/binary_size/libsupersize/integration_test.py ('k') | tools/binary_size/libsupersize/models.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/binary_size/libsupersize/linker_map_parser.py
diff --git a/tools/binary_size/libsupersize/linker_map_parser.py b/tools/binary_size/libsupersize/linker_map_parser.py
index f239013d707922a95cc1f63625a37f555ed03de6..21119b3d60809a1d7fbe2e92b6327449b901bcc9 100644
--- a/tools/binary_size/libsupersize/linker_map_parser.py
+++ b/tools/binary_size/libsupersize/linker_map_parser.py
@@ -79,7 +79,7 @@ class MapFileParser(object):
if not parts:
break
name, size_str, path = parts
- sym = models.Symbol('.bss', int(size_str[2:], 16), name=name,
+ sym = models.Symbol('.bss', int(size_str[2:], 16), full_name=name,
object_path=path)
ret.append(sym)
return ret
@@ -159,7 +159,7 @@ class MapFileParser(object):
size = int(size_str[2:], 16)
path = None
sym = models.Symbol(section_name, size, address=address,
- name=name, object_path=path)
+ full_name=name, object_path=path)
syms.append(sym)
else:
# A normal symbol entry.
@@ -218,12 +218,13 @@ class MapFileParser(object):
sym = models.Symbol(
section_name, 0,
address=address,
- name='** symbol gap %d' % symbol_gap_count)
+ full_name='** symbol gap %d' % symbol_gap_count)
symbol_gap_count += 1
syms.append(sym)
sym = models.Symbol(section_name, size, address=address,
- name=name or mangled_name, object_path=path)
+ full_name=name or mangled_name,
+ object_path=path)
syms.append(sym)
section_end_address = section_address + section_size
if section_name != '.bss' and (
@@ -232,7 +233,8 @@ class MapFileParser(object):
sym = models.Symbol(
section_name, 0,
address=section_end_address,
- name='** symbol gap %d (end of section)' % symbol_gap_count)
+ full_name=(
+ '** symbol gap %d (end of section)' % symbol_gap_count))
syms.append(sym)
logging.debug('Symbol count for %s: %d', section_name,
len(syms) - sym_count_at_start)
« no previous file with comments | « tools/binary_size/libsupersize/integration_test.py ('k') | tools/binary_size/libsupersize/models.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698