Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(18)

Issue 2870633002: Use ScopedTaskEnvironment instead of MessageLoop in RenderViewTest. (Closed)

Created:
1 year, 10 months ago by fdoray
Modified:
1 year, 10 months ago
Reviewers:
jam, sky
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, nasko+codewatch_chromium.org, jam, mathp+autofillwatch_chromium.org, darin-cc_chromium.org, mac-reviews_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ScopedTaskEnvironment instead of MessageLoop in RenderViewTest. ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and base/task_scheduler/post_task.h within its scope. It should be instantiated in everytest that uses either of these APIs (i.e. no test should instantiate a MessageLoop directly). Motivation for ScopedTaskEnvironment can be found in: https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit This CL also removes RenderViewTest::ProcessPendingMessages(). BUG=708584 TBR=jam@chromium.org Review-Url: https://codereview.chromium.org/2870633002 Cr-Commit-Position: refs/heads/master@{#470047} Committed: https://chromium.googlesource.com/chromium/src/+/752948ba8f63184d42f7188a82d5580686e428f6

Patch Set 1 #

Patch Set 2 : fix-build-error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -63 lines) Patch
M chrome/renderer/autofill/form_autocomplete_browsertest.cc View 14 chunks +15 lines, -15 lines 0 comments Download
M chrome/renderer/content_settings_observer_browsertest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M components/printing/test/print_web_view_helper_browsertest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/public/test/render_view_test.h View 3 chunks +4 lines, -5 lines 0 comments Download
M content/public/test/render_view_test.cc View 1 2 chunks +1 line, -7 lines 0 comments Download
M content/renderer/render_frame_impl_browsertest.cc View 8 chunks +10 lines, -9 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 17 chunks +18 lines, -17 lines 0 comments Download
M content/renderer/render_view_browsertest_mac.mm View 5 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 23 (16 generated)
fdoray
PTAL This is a change that you requested in https://codereview.chromium.org/2852373004/
1 year, 10 months ago (2017-05-08 15:19:37 UTC) #5
sky
Thanks, LGTM
1 year, 10 months ago (2017-05-08 16:12:07 UTC) #8
fdoray
TBR jam@ for trivial content/renderer/ and components/ changes
1 year, 10 months ago (2017-05-08 16:43:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870633002/20001
1 year, 10 months ago (2017-05-08 16:44:09 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/209713)
1 year, 10 months ago (2017-05-08 16:58:42 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2870633002/20001
1 year, 10 months ago (2017-05-08 17:10:13 UTC) #20
commit-bot: I haz the power
1 year, 10 months ago (2017-05-08 18:04:37 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/752948ba8f63184d42f7188a82d5...

Powered by Google App Engine
This is Rietveld 408576698