Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: content/public/test/render_view_test.cc

Issue 2870633002: Use ScopedTaskEnvironment instead of MessageLoop in RenderViewTest. (Closed)
Patch Set: fix-build-error Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/test/render_view_test.h ('k') | content/renderer/render_frame_impl_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/test/render_view_test.cc
diff --git a/content/public/test/render_view_test.cc b/content/public/test/render_view_test.cc
index e04ab92c730ea71ff925a9415a3d9207f1aed6e1..aee7cdfb21d1f101fc74b23a3772a6a3565ca41d 100644
--- a/content/public/test/render_view_test.cc
+++ b/content/public/test/render_view_test.cc
@@ -156,12 +156,6 @@ RenderViewTest::RenderViewTest()
RenderViewTest::~RenderViewTest() {
}
-void RenderViewTest::ProcessPendingMessages() {
- msg_loop_.task_runner()->PostTask(FROM_HERE,
- base::MessageLoop::QuitWhenIdleClosure());
- base::RunLoop().Run();
-}
-
WebLocalFrame* RenderViewTest::GetMainFrame() {
return view_->GetWebView()->MainFrame()->ToWebLocalFrame();
}
@@ -322,7 +316,7 @@ void RenderViewTest::SetUp() {
void RenderViewTest::TearDown() {
// Run the loop so the release task from the renderwidget executes.
- ProcessPendingMessages();
+ base::RunLoop().RunUntilIdle();
render_thread_->SendCloseMessage();
« no previous file with comments | « content/public/test/render_view_test.h ('k') | content/renderer/render_frame_impl_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698