In-product-help: Accessibility text

In-product-help: Accessibility text

BUG=711155
Review-Url: https://codereview.chromium.org/2870313002
Cr-Commit-Position: refs/heads/master@{#471007}
Committed: https://chromium.googlesource.com/chromium/src/+/dedb6d42c8dfc344c00acc620b57c83ad94cbc38

[shaktisahu, 2017-05-10 20:14:38]

shaktisahu@chromium.org changed reviewers:
+ dtrainor@chromium.org

[shaktisahu, 2017-05-10 20:14:39]

PTAL.

I still have to add the right string resources for accessibility.

[David Trainor- moved to gerrit, 2017-05-10 22:48:11]

lgtm.  +twellington@ for fyi regarding the comment about the bubble over the
bottom sheet.  Since it says something like, "swipe here" we'll probably need
some different text for when we're announcing for accessibility.

https://codereview.chromium.org/2870313002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java
(right):

https://codereview.chromium.org/2870313002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java:1165:
R.string.bottom_sheet_help_bubble_message);
Can you file a bug against twellington@ to triage and figure out the
accessibility string here (if we want a different one)?

https://codereview.chromium.org/2870313002/diff/20001/chrome/android/java/str...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/2870313002/diff/20001/chrome/android/java/str...
chrome/android/java/strings/android_chrome_strings.grd:2971: <message
name="IDS_IPH_DOWNLOAD_PAGE_FOR_OFFLINE_USAGE_ACCESSIBILITY_TEXT" desc="The
in-product-help message after a successful navigation prompting user to download
the pages to view offline.">
Can you mention accessibility in the description for this one?

[shaktisahu, 2017-05-10 23:53:05]

Patchset #3 (id:40001) has been deleted

[shaktisahu, 2017-05-11 00:30:51]

shaktisahu@chromium.org changed reviewers:
+ miguelg@chromium.org

[shaktisahu, 2017-05-11 00:30:52]

miguelg@ - PTAL at chrome/browser/infobar

[Theresa, 2017-05-11 15:35:26]

twellington@chromium.org changed reviewers:
+ twellington@chromium.org

[Theresa, 2017-05-11 15:35:27]

https://codereview.chromium.org/2870313002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java
(right):

https://codereview.chromium.org/2870313002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java:1165:
R.string.bottom_sheet_help_bubble_message);
On 2017/05/10 22:48:11, David Trainor-ping if over 24h wrote:
> Can you file a bug against twellington@ to triage and figure out the
> accessibility string here (if we want a different one)?

Can you please file, assign to hannahs@ and cc me?

[Miguel Garcia, 2017-05-11 15:37:42]

lgtm on
chrome/android/java/src/org/chromium/chrome/browser/infobar/IPHInfoBarSupport.java

[shaktisahu, 2017-05-11 16:51:45]

The CQ bit was checked by shaktisahu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 16:52:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shaktisahu, 2017-05-11 17:22:32]

https://codereview.chromium.org/2870313002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java
(right):

https://codereview.chromium.org/2870313002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java:1165:
R.string.bottom_sheet_help_bubble_message);
On 2017/05/11 15:35:27, Theresa wrote:
> On 2017/05/10 22:48:11, David Trainor-ping if over 24h wrote:
> > Can you file a bug against twellington@ to triage and figure out the
> > accessibility string here (if we want a different one)?
> 
> Can you please file, assign to hannahs@ and cc me?

I checked with srahim@. The string "Pull up to see bookmarks and more" should
work also for Talkback since it is the same gesture (except using two fingers to
pull up :))

https://codereview.chromium.org/2870313002/diff/20001/chrome/android/java/str...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/2870313002/diff/20001/chrome/android/java/str...
chrome/android/java/strings/android_chrome_strings.grd:2971: <message
name="IDS_IPH_DOWNLOAD_PAGE_FOR_OFFLINE_USAGE_ACCESSIBILITY_TEXT" desc="The
in-product-help message after a successful navigation prompting user to download
the pages to view offline.">
On 2017/05/10 22:48:11, David Trainor-ping if over 24h wrote:
> Can you mention accessibility in the description for this one?

Done.

[commit-bot: I haz the power, 2017-05-11 17:39:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 17:39:22]

Dry run: This issue passed the CQ dry run.

[shaktisahu, 2017-05-11 17:52:33]

The CQ bit was checked by shaktisahu@chromium.org

[shaktisahu, 2017-05-11 17:52:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org, miguelg@chromium.org
Link to the patchset: https://codereview.chromium.org/2870313002/#ps80001
(title: "strings")

[commit-bot: I haz the power, 2017-05-11 17:53:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 17:59:25]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494525153216840,
"parent_rev": "42f43cb31dd1ab13aa264e62d1967a4dcbd0dfa7", "commit_rev":
"dedb6d42c8dfc344c00acc620b57c83ad94cbc38"}

[commit-bot: I haz the power, 2017-05-11 17:59:32]

Description was changed from

==========
In-product-help: Accessibility text

BUG=711155
==========

to

==========
In-product-help: Accessibility text

BUG=711155

Review-Url: https://codereview.chromium.org/2870313002
Cr-Commit-Position: refs/heads/master@{#471007}
Committed:
https://chromium.googlesource.com/chromium/src/+/dedb6d42c8dfc344c00acc620b57...
==========

[commit-bot: I haz the power, 2017-05-11 17:59:34]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/dedb6d42c8dfc344c00acc620b57...