Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3504)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/IPHInfoBarSupport.java

Issue 2870313002: In-product-help: Accessibility text (Closed)
Patch Set: strings Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/IPHInfoBarSupport.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/IPHInfoBarSupport.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/IPHInfoBarSupport.java
index f4a986f50a2f810249279dac6d973d0ae7dd1c82..06dde0a0645fcc0be2b0340547abe4fa51c45ea9 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/IPHInfoBarSupport.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/IPHInfoBarSupport.java
@@ -33,9 +33,11 @@ class IPHInfoBarSupport implements OnDismissListener, InfoBarContainer.InfoBarAn
/** Helper class to hold all relevant display parameters for an in-product help window. */
private static class TrackerParameters {
- public TrackerParameters(String feature, @StringRes int textId) {
+ public TrackerParameters(
+ String feature, @StringRes int textId, @StringRes int accessibilityTextId) {
this.feature = feature;
this.textId = textId;
+ this.accessibilityTextId = accessibilityTextId;
}
/** @see FeatureConstants */
@@ -43,6 +45,9 @@ class IPHInfoBarSupport implements OnDismissListener, InfoBarContainer.InfoBarAn
@StringRes
public int textId;
+
+ @StringRes
+ public int accessibilityTextId;
}
/** Helper class to manage state relating to a particular instance of an in-product window. */
@@ -93,7 +98,8 @@ class IPHInfoBarSupport implements OnDismissListener, InfoBarContainer.InfoBarAn
mCurrentState = new PopupState();
mCurrentState.view = view;
- mCurrentState.bubble = new ViewAnchoredTextBubble(mContext, view, params.textId);
+ mCurrentState.bubble = new ViewAnchoredTextBubble(
+ mContext, view, params.textId, params.accessibilityTextId);
mCurrentState.bubble.addOnDismissListener(this);
mCurrentState.bubble.setDismissOnTouchInteraction(true);
mCurrentState.bubble.show();
@@ -134,8 +140,8 @@ class IPHInfoBarSupport implements OnDismissListener, InfoBarContainer.InfoBarAn
private TrackerParameters getTrackerParameters(Item infoBar) {
switch (infoBar.getInfoBarIdentifier()) {
case InfoBarIdentifier.DATA_REDUCTION_PROXY_PREVIEW_INFOBAR_DELEGATE:
- return new TrackerParameters(
- FeatureConstants.DATA_SAVER_PREVIEW, R.string.iph_data_saver_preview_text);
+ return new TrackerParameters(FeatureConstants.DATA_SAVER_PREVIEW,
+ R.string.iph_data_saver_preview_text, R.string.iph_data_saver_preview_text);
default:
return null;
}

Powered by Google App Engine
This is Rietveld 408576698