Issue 287003004: Revert 270867 "Mojo: Internalize ServiceConnector<>"

Issue 287003004: Revert 270867 "Mojo: Internalize ServiceConnector<>" (Closed)

Created:
6 years, 7 months ago by jiayl

Modified:
6 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 270867 "Mojo: Internalize ServiceConnector<>" Suspected to cause compile failure on Win Builder: http://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/20401 > Mojo: Internalize ServiceConnector<> > > Authored by davemoore@chromium.org, see https://codereview.chromium.org/275363002/ > > R=viettrungluu@chromium.org, darin@chromium.org > > Review URL: https://codereview.chromium.org/284113009 TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270873

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+100 lines, -350 lines)			Patch
M	trunk/src/mojo/dbus/dbus_external_service.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/mojo/examples/launcher/launcher.cc	View	3 chunks	+9 lines, -7 lines	0 comments	Download
M	trunk/src/mojo/mojo_public.gypi	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	trunk/src/mojo/public/cpp/bindings/error_handler.h	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	trunk/src/mojo/public/cpp/bindings/interface_impl.h	View	1 chunk	+5 lines, -4 lines	0 comments	Download
M	trunk/src/mojo/public/cpp/bindings/lib/interface_impl_internal.h	View	3 chunks	+4 lines, -16 lines	0 comments	Download
M	trunk/src/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc	View	3 chunks	+3 lines, -15 lines	0 comments	Download
M	trunk/src/mojo/public/cpp/shell/application.h	View	2 chunks	+7 lines, -53 lines	0 comments	Download
D	trunk/src/mojo/public/cpp/shell/connect.h	View	1 chunk	+0 lines, -25 lines	0 comments	Download
A +	trunk/src/mojo/public/cpp/shell/lib/service.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	trunk/src/mojo/public/cpp/shell/lib/service_connector.h	View	1 chunk	+0 lines, -141 lines	0 comments	Download
D	trunk/src/mojo/public/cpp/shell/lib/service_connector.cc	View	1 chunk	+0 lines, -20 lines	0 comments	Download
A +	trunk/src/mojo/public/cpp/shell/service.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	trunk/src/mojo/service_manager/service_manager_unittest.cc	View	2 chunks	+10 lines, -13 lines	0 comments	Download
M	trunk/src/mojo/services/dbus_echo/dbus_echo_service.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	trunk/src/mojo/services/native_viewport/native_viewport_service.cc	View	4 chunks	+9 lines, -9 lines	0 comments	Download
M	trunk/src/mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/mojo/services/view_manager/main.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	trunk/src/mojo/services/view_manager/root_view_manager.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/mojo/services/view_manager/view_manager_connection.h	View	3 chunks	+8 lines, -7 lines	0 comments	Download
M	trunk/src/mojo/services/view_manager/view_manager_connection.cc	View	13 chunks	+22 lines, -28 lines	0 comments	Download
M	trunk/src/mojo/services/view_manager/view_manager_connection_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/mojo/shell/view_manager_loader.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jiayl

Committed patchset #1 manually as r270873 (tree was closed).

6 years, 7 months ago (2014-05-16 00:28:07 UTC) #2

Message was sent while issue was closed.

LGTM

Apologies for the bustage!

Expand Messages | Collapse Messages