Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1243)

Unified Diff: trunk/src/mojo/services/view_manager/view_manager_connection.h

Issue 287003004: Revert 270867 "Mojo: Internalize ServiceConnector<>" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/mojo/services/view_manager/view_manager_connection.h
===================================================================
--- trunk/src/mojo/services/view_manager/view_manager_connection.h (revision 270872)
+++ trunk/src/mojo/services/view_manager/view_manager_connection.h (working copy)
@@ -9,6 +9,7 @@
#include "base/basictypes.h"
#include "base/compiler_specific.h"
+#include "mojo/public/cpp/shell/service.h"
#include "mojo/services/public/interfaces/view_manager/view_manager.mojom.h"
#include "mojo/services/view_manager/ids.h"
#include "mojo/services/view_manager/node_delegate.h"
@@ -31,17 +32,18 @@
// Manages a connection from the client.
class MOJO_VIEW_MANAGER_EXPORT ViewManagerConnection
- : public InterfaceImpl<IViewManager>,
+ : public ServiceConnection<IViewManager, ViewManagerConnection,
+ RootNodeManager>,
public NodeDelegate {
public:
- ViewManagerConnection(RootNodeManager* root_node_manager);
+ ViewManagerConnection();
virtual ~ViewManagerConnection();
- virtual void OnConnectionEstablished() MOJO_OVERRIDE;
- virtual void OnConnectionError() MOJO_OVERRIDE;
-
TransportConnectionId id() const { return id_; }
+ // Invoked when connection is established.
+ void Initialize();
+
// Returns the Node with the specified id.
Node* GetNode(const NodeId& id);
@@ -109,10 +111,9 @@
virtual void OnNodeViewReplaced(const NodeId& node,
const ViewId& new_view_id,
const ViewId& old_view_id) OVERRIDE;
- RootNodeManager* root_node_manager_;
// Id of this connection as assigned by RootNodeManager. Assigned in
- // OnConnectionEstablished().
+ // Initialize().
TransportConnectionId id_;
NodeMap node_map_;

Powered by Google App Engine
This is Rietveld 408576698