Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: trunk/src/mojo/public/cpp/bindings/interface_impl.h

Issue 287003004: Revert 270867 "Mojo: Internalize ServiceConnector<>" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/mojo/public/cpp/bindings/interface_impl.h
===================================================================
--- trunk/src/mojo/public/cpp/bindings/interface_impl.h (revision 270872)
+++ trunk/src/mojo/public/cpp/bindings/interface_impl.h (working copy)
@@ -13,17 +13,18 @@
// InterfaceImpl<..> is designed to be the base class of an interface
// implementation. It may be bound to a pipe or a proxy, see BindToPipe and
// BindToProxy.
+//
+// NOTE: A base class of WithErrorHandler<Interface> is used to avoid multiple
+// inheritance. This base class inserts the signature of ErrorHandler into the
+// inheritance chain.
template <typename Interface>
-class InterfaceImpl : public internal::InterfaceImplBase<Interface> {
+class InterfaceImpl : public WithErrorHandler<Interface> {
public:
typedef typename Interface::Client Client;
InterfaceImpl() : internal_state_(this) {}
virtual ~InterfaceImpl() {}
- // Subclasses can override this to handle post connection initialization.
- virtual void OnConnectionEstablished() {}
-
// Subclasses must handle connection errors.
virtual void OnConnectionError() = 0;
« no previous file with comments | « trunk/src/mojo/public/cpp/bindings/error_handler.h ('k') | trunk/src/mojo/public/cpp/bindings/lib/interface_impl_internal.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698