Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 284113009: Mojo: Internalize ServiceConnector<> (Closed)

Created:
6 years, 7 months ago by darin (slow to review)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, ben+mojo_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -423 lines) Patch
M mojo/dbus/dbus_external_service.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/launcher/launcher.cc View 3 chunks +7 lines, -9 lines 0 comments Download
M mojo/mojo_public.gypi View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/error_handler.h View 1 chunk +0 lines, -9 lines 0 comments Download
M mojo/public/cpp/bindings/interface_impl.h View 1 chunk +4 lines, -5 lines 0 comments Download
M mojo/public/cpp/bindings/lib/interface_impl_internal.h View 3 chunks +16 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc View 3 chunks +15 lines, -3 lines 0 comments Download
M mojo/public/cpp/shell/application.h View 2 chunks +53 lines, -7 lines 0 comments Download
A mojo/public/cpp/shell/connect.h View 1 chunk +25 lines, -0 lines 0 comments Download
D mojo/public/cpp/shell/lib/service.cc View 1 chunk +0 lines, -20 lines 0 comments Download
A + mojo/public/cpp/shell/lib/service_connector.h View 5 chunks +53 lines, -106 lines 0 comments Download
A + mojo/public/cpp/shell/lib/service_connector.cc View 1 chunk +1 line, -1 line 0 comments Download
D mojo/public/cpp/shell/service.h View 1 chunk +0 lines, -194 lines 0 comments Download
M mojo/service_manager/service_manager_unittest.cc View 2 chunks +13 lines, -10 lines 0 comments Download
M mojo/services/dbus_echo/dbus_echo_service.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/services/native_viewport/native_viewport_service.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/main.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M mojo/services/view_manager/root_view_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/view_manager_connection.h View 3 chunks +7 lines, -8 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection.cc View 13 chunks +28 lines, -22 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/view_manager_loader.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
rubberstamp lgtm
6 years, 7 months ago (2014-05-15 22:30:46 UTC) #1
darin (slow to review)
The CQ bit was checked by darin@chromium.org
6 years, 7 months ago (2014-05-15 22:44:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/284113009/1
6 years, 7 months ago (2014-05-15 22:44:55 UTC) #3
darin (slow to review)
6 years, 7 months ago (2014-05-16 00:02:15 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 manually as r270867 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698