Issue 286993005: refactor DM::SetupBitmap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 286993005: refactor DM::SetupBitmap (Closed)

Created:
6 years, 7 months ago by mtklein_C

Modified:
6 years, 7 months ago

Reviewers:
mtklein, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

refactor DM::SetupBitmap Seemed sort of repetitive. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14752

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -28 lines)			Patch
M	dm/DMBenchTask.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dm/DMCpuGMTask.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dm/DMPipeTask.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dm/DMQuiltTask.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dm/DMRecordTask.cpp	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	dm/DMReplayTask.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dm/DMSKPTask.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dm/DMSerializeTask.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dm/DMUtil.h	View	1 chunk	+4 lines, -5 lines	0 comments	Download
M	dm/DMUtil.cpp	View	1 chunk	+3 lines, -11 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/286993005/1

6 years, 7 months ago (2014-05-15 17:28:14 UTC) #4

Message was sent while issue was closed.

Change committed as 14752