dm/DMReplayTask.cpp - Issue 286993005: refactor DM::SetupBitmap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dm/DMReplayTask.cpp

Issue 286993005: refactor DM::SetupBitmap (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dm/DMReplayTask.cpp

diff --git a/dm/DMReplayTask.cpp b/dm/DMReplayTask.cpp

index a126f2cfe2162cd5b8cea565deaf1d65136c1401..86838795d26d0929c4d092c4e6ca00070bf77fce 100644

--- a/dm/DMReplayTask.cpp

+++ b/dm/DMReplayTask.cpp

@@ -30,7 +30,7 @@ void ReplayTask::draw() {

SkAutoTUnref<SkPicture> recorded(RecordPicture(fGM.get(), 0, factory.get()));

SkBitmap bitmap;

- SetupBitmap(fReference.colorType(), fGM.get(), &bitmap);

+ AllocatePixels(fReference, &bitmap);

DrawPicture(recorded, &bitmap);

if (!BitmapsEqual(bitmap, fReference)) {

this->fail();

« no previous file with comments | « dm/DMRecordTask.cpp ('k') | dm/DMSKPTask.cpp » ('j') | no next file with comments »