dm/DMSKPTask.cpp - Issue 286993005: refactor DM::SetupBitmap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dm/DMSKPTask.cpp

Issue 286993005: refactor DM::SetupBitmap (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dm/DMSKPTask.cpp

diff --git a/dm/DMSKPTask.cpp b/dm/DMSKPTask.cpp

index 53f8408b99efa9edeeca768cfb4373325408e42f..04c4184846e00fe1e84c5bb93c190c92a57785b5 100644

--- a/dm/DMSKPTask.cpp

+++ b/dm/DMSKPTask.cpp

@@ -19,7 +19,7 @@ SKPTask::SKPTask(Reporter* r, TaskRunner* tr, SkPicture* pic, SkString filename)

void SKPTask::draw() {

SkBitmap bitmap;

- SetupBitmap(kN32_SkColorType, *fPicture, &bitmap);

+ AllocatePixels(kN32_SkColorType, fPicture->width(), fPicture->height(), &bitmap);

DrawPicture(fPicture, &bitmap);

this->spawnChild(SkNEW_ARGS(RecordTask,

« no previous file with comments | « dm/DMReplayTask.cpp ('k') | dm/DMSerializeTask.cpp » ('j') | no next file with comments »