dm/DMSerializeTask.cpp - Issue 286993005: refactor DM::SetupBitmap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dm/DMSerializeTask.cpp

Issue 286993005: refactor DM::SetupBitmap (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dm/DMSerializeTask.cpp

diff --git a/dm/DMSerializeTask.cpp b/dm/DMSerializeTask.cpp

index aa0dabe0acfa1e625f82ae761f1802e8166cf702..62c45b3f048924c06fd2439b1b7fe5ea8446385c 100644

--- a/dm/DMSerializeTask.cpp

+++ b/dm/DMSerializeTask.cpp

@@ -28,7 +28,7 @@ void SerializeTask::draw() {

SkAutoTUnref<SkPicture> reconstructed(SkPicture::CreateFromStream(rStream));

SkBitmap bitmap;

- SetupBitmap(fReference.colorType(), fGM.get(), &bitmap);

+ AllocatePixels(fReference, &bitmap);

DrawPicture(reconstructed, &bitmap);

if (!BitmapsEqual(bitmap, fReference)) {

this->fail();

« no previous file with comments | « dm/DMSKPTask.cpp ('k') | dm/DMUtil.h » ('j') | no next file with comments »