Remove unused flag 'kDisableSmartVirtualKeyboard' and associated code.

Remove unused flag 'kDisableSmartVirtualKeyboard' and associated code.

BUG=706720
Review-Url: https://codereview.chromium.org/2869773003
Cr-Commit-Position: refs/heads/master@{#472361}
Committed: https://chromium.googlesource.com/chromium/src/+/9f62045624ff520d1de54297a13977dfa6d7e36a

[Blake O(Apostrophe)Hare, 2017-05-09 03:50:32]

Description was changed from

==========
Remove unused flag 'kDisableSmartVirtualKeyboard' and associated code.

BUG=706720
==========

to

==========
Remove unused flag 'kDisableSmartVirtualKeyboard' and associated code.

BUG=706720
==========

[Blake O(Apostrophe)Hare, 2017-05-09 03:50:33]

blakeo@chromium.org changed reviewers:
+ oka@chromium.org

[oka, 2017-05-09 23:42:08]

oka@chromium.org changed reviewers:
+ holte@chromium.org, oshima@chromium.org, sadrul@chromium.org

[oka, 2017-05-09 23:47:37]

Sorry I forgot to tell you about it, but please "Publish+Mail Comments" when
your CL is ready so that reviewers receive email.

Also, you should get approval (i.e. l-g-t-m) from OWNERs of changed files to
submit your change. (Unfortunatelly I'm not an owner of any keyboard related
file yet.)

I added the reviewers:
holte@ - for histogram
sadrul@ - for ui/keyboard
oshima@ - for ash

[Blake O(Apostrophe)Hare, 2017-05-10 00:37:28]

The CQ bit was checked by blakeo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 00:39:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 00:44:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 00:44:40]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Steven Holte, 2017-05-10 01:01:03]

On 2017/05/09 23:47:37, oka wrote:
> Sorry I forgot to tell you about it, but please "Publish+Mail Comments" when
> your CL is ready so that reviewers receive email.
> 
> Also, you should get approval (i.e. l-g-t-m) from OWNERs of changed files to
> submit your change. (Unfortunatelly I'm not an owner of any keyboard related
> file yet.)
> 
> I added the reviewers:
> holte@ - for histogram
> sadrul@ - for ui/keyboard
> oshima@ - for ash

Your histograms.xml change would be rebased to enums.xml, but it's actually
preferred not to remove old enum values, since they are may be still sent by old
versions.

[yhanada, 2017-05-10 01:03:58]

yhanada@chromium.org changed reviewers:
+ yhanada@chromium.org

[yhanada, 2017-05-10 01:03:58]

https://codereview.chromium.org/2869773003/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (left):

https://codereview.chromium.org/2869773003/diff/1/chrome/browser/about_flags....
chrome/browser/about_flags.cc:1470:
flag_descriptions::kSmartVirtualKeyboardDescription, kOsCrOS,
Could you also remove flag_descriptions::kSmartVirtualKeyboard{Name,
Description}?

[Blake O(Apostrophe)Hare, 2017-05-10 01:08:54]

The CQ bit was checked by blakeo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 01:09:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 01:14:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 01:14:46]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Blake, 2017-05-10 01:28:15]

blakeo@google.com changed reviewers:
+ blakeo@google.com

[Blake, 2017-05-10 01:28:16]

https://codereview.chromium.org/2869773003/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (left):

https://codereview.chromium.org/2869773003/diff/1/chrome/browser/about_flags....
chrome/browser/about_flags.cc:1470:
flag_descriptions::kSmartVirtualKeyboardDescription, kOsCrOS,
On 2017/05/10 01:03:58, yhanada wrote:
> Could you also remove flag_descriptions::kSmartVirtualKeyboard{Name,
> Description}?

Done.

[Blake O(Apostrophe)Hare, 2017-05-10 01:29:04]

The CQ bit was checked by blakeo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 01:30:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 03:34:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 03:34:06]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has
not started yet; builder either lacks capacity or does not exist (misspelled?))
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet;
builder either lacks capacity or does not exist (misspelled?))
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
build has not started yet; builder either lacks capacity or does not exist
(misspelled?))
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build
has not started yet; builder either lacks capacity or does not exist
(misspelled?))

[yhanada, 2017-05-11 01:58:12]

On 2017/05/10 01:28:16, Blake wrote:
>
https://codereview.chromium.org/2869773003/diff/1/chrome/browser/about_flags.cc
> File chrome/browser/about_flags.cc (left):
> 
>
https://codereview.chromium.org/2869773003/diff/1/chrome/browser/about_flags....
> chrome/browser/about_flags.cc:1470:
> flag_descriptions::kSmartVirtualKeyboardDescription, kOsCrOS,
> On 2017/05/10 01:03:58, yhanada wrote:
> > Could you also remove flag_descriptions::kSmartVirtualKeyboard{Name,
> > Description}?
> 
> Done.

Thanks! Could you rebase this change? Rebasing may fix the compile errors.

[Blake, 2017-05-11 03:27:11]

The CQ bit was checked by blakeo@google.com

[commit-bot: I haz the power, 2017-05-11 03:28:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 03:28:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 03:28:08]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[Blake O(Apostrophe)Hare, 2017-05-11 03:48:09]

The CQ bit was checked by blakeo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 03:49:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Blake O(Apostrophe)Hare, 2017-05-11 04:11:25]

The CQ bit was checked by blakeo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 04:12:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 04:53:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 04:53:50]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2017-05-11 21:09:33]

lgtm

[sadrul, 2017-05-11 23:39:08]

lgtm

[Blake O(Apostrophe)Hare, 2017-05-15 05:01:06]

The CQ bit was checked by blakeo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 05:01:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 05:04:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 05:04:39]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Blake O(Apostrophe)Hare, 2017-05-15 05:06:32]

The CQ bit was checked by blakeo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 05:06:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 05:10:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 05:10:02]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Blake O(Apostrophe)Hare, 2017-05-15 05:27:22]

The CQ bit was checked by blakeo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 05:27:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 05:31:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 05:31:01]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Blake O(Apostrophe)Hare, 2017-05-15 06:43:27]

The CQ bit was checked by blakeo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 06:43:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 07:11:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 07:11:11]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Blake O(Apostrophe)Hare, 2017-05-15 07:35:23]

The CQ bit was checked by blakeo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 07:35:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 07:59:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 07:59:46]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Blake O(Apostrophe)Hare, 2017-05-15 08:24:08]

The CQ bit was checked by blakeo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 08:24:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 08:58:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 08:58:25]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Blake O(Apostrophe)Hare, 2017-05-16 07:02:21]

The CQ bit was checked by blakeo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 07:02:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Blake O(Apostrophe)Hare, 2017-05-16 07:12:11]

The CQ bit was checked by blakeo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 07:12:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 07:57:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 07:57:29]

Dry run: This issue passed the CQ dry run.

[Blake, 2017-05-17 06:52:36]

The CQ bit was checked by blakeo@google.com

[Blake, 2017-05-17 06:52:37]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org,
oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2869773003/#ps200001
(title: "Fix accidental merge in the wrong direction")

[commit-bot: I haz the power, 2017-05-17 06:53:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 06:59:39]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1495003956852180,
"parent_rev": "1b251fc2b0c7d5f2661188e5c3913642ae472b7b", "commit_rev":
"9f62045624ff520d1de54297a13977dfa6d7e36a"}

[commit-bot: I haz the power, 2017-05-17 06:59:55]

Description was changed from

==========
Remove unused flag 'kDisableSmartVirtualKeyboard' and associated code.

BUG=706720
==========

to

==========
Remove unused flag 'kDisableSmartVirtualKeyboard' and associated code.

BUG=706720

Review-Url: https://codereview.chromium.org/2869773003
Cr-Commit-Position: refs/heads/master@{#472361}
Committed:
https://chromium.googlesource.com/chromium/src/+/9f62045624ff520d1de54297a139...
==========

[commit-bot: I haz the power, 2017-05-17 06:59:57]

Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/9f62045624ff520d1de54297a139...