Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2869773003: Remove unused flag 'kDisableSmartVirtualKeyboard' and associated code. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/virtual_keyboard_controller.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 1448 matching lines...) Expand 10 before | Expand all | Expand 10 after
1459 SINGLE_DISABLE_VALUE_TYPE(keyboard::switches::kDisableVoiceInput)}, 1459 SINGLE_DISABLE_VALUE_TYPE(keyboard::switches::kDisableVoiceInput)},
1460 {"experimental-input-view-features", 1460 {"experimental-input-view-features",
1461 flag_descriptions::kExperimentalInputViewFeaturesName, 1461 flag_descriptions::kExperimentalInputViewFeaturesName,
1462 flag_descriptions::kExperimentalInputViewFeaturesDescription, kOsCrOS, 1462 flag_descriptions::kExperimentalInputViewFeaturesDescription, kOsCrOS,
1463 SINGLE_VALUE_TYPE( 1463 SINGLE_VALUE_TYPE(
1464 keyboard::switches::kEnableExperimentalInputViewFeatures)}, 1464 keyboard::switches::kEnableExperimentalInputViewFeatures)},
1465 {"floating-virtual-keyboard", 1465 {"floating-virtual-keyboard",
1466 flag_descriptions::kFloatingVirtualKeyboardName, 1466 flag_descriptions::kFloatingVirtualKeyboardName,
1467 flag_descriptions::kFloatingVirtualKeyboardDescription, kOsCrOS, 1467 flag_descriptions::kFloatingVirtualKeyboardDescription, kOsCrOS,
1468 SINGLE_VALUE_TYPE(keyboard::switches::kEnableFloatingVirtualKeyboard)}, 1468 SINGLE_VALUE_TYPE(keyboard::switches::kEnableFloatingVirtualKeyboard)},
1469 {"smart-virtual-keyboard", flag_descriptions::kSmartVirtualKeyboardName,
1470 flag_descriptions::kSmartVirtualKeyboardDescription, kOsCrOS,
yhanada 2017/05/10 01:03:58 Could you also remove flag_descriptions::kSmartVir
Blake 2017/05/10 01:28:16 Done.
1471 SINGLE_DISABLE_VALUE_TYPE(
1472 keyboard::switches::kDisableSmartVirtualKeyboard)},
1473 {"gesture-typing", flag_descriptions::kGestureTypingName, 1469 {"gesture-typing", flag_descriptions::kGestureTypingName,
1474 flag_descriptions::kGestureTypingDescription, kOsCrOS, 1470 flag_descriptions::kGestureTypingDescription, kOsCrOS,
1475 SINGLE_DISABLE_VALUE_TYPE(keyboard::switches::kDisableGestureTyping)}, 1471 SINGLE_DISABLE_VALUE_TYPE(keyboard::switches::kDisableGestureTyping)},
1476 {"gesture-editing", flag_descriptions::kGestureEditingName, 1472 {"gesture-editing", flag_descriptions::kGestureEditingName,
1477 flag_descriptions::kGestureEditingDescription, kOsCrOS, 1473 flag_descriptions::kGestureEditingDescription, kOsCrOS,
1478 SINGLE_DISABLE_VALUE_TYPE(keyboard::switches::kDisableGestureEditing)}, 1474 SINGLE_DISABLE_VALUE_TYPE(keyboard::switches::kDisableGestureEditing)},
1479 #endif // OS_CHROMEOS 1475 #endif // OS_CHROMEOS
1480 {"enable-simple-cache-backend", flag_descriptions::kSimpleCacheBackendName, 1476 {"enable-simple-cache-backend", flag_descriptions::kSimpleCacheBackendName,
1481 flag_descriptions::kSimpleCacheBackendDescription, 1477 flag_descriptions::kSimpleCacheBackendDescription,
1482 kOsWin | kOsMac | kOsLinux | kOsCrOS, 1478 kOsWin | kOsMac | kOsLinux | kOsCrOS,
(...skipping 1494 matching lines...) Expand 10 before | Expand all | Expand 10 after
2977 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2973 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2978 2974
2979 const FeatureEntry* GetFeatureEntries(size_t* count) { 2975 const FeatureEntry* GetFeatureEntries(size_t* count) {
2980 *count = arraysize(kFeatureEntries); 2976 *count = arraysize(kFeatureEntries);
2981 return kFeatureEntries; 2977 return kFeatureEntries;
2982 } 2978 }
2983 2979
2984 } // namespace testing 2980 } // namespace testing
2985 2981
2986 } // namespace about_flags 2982 } // namespace about_flags
OLDNEW
« no previous file with comments | « ash/virtual_keyboard_controller.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698