Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: ash/virtual_keyboard_controller_unittest.cc

Issue 2869773003: Remove unused flag 'kDisableSmartVirtualKeyboard' and associated code. (Closed)
Patch Set: Fix accidental merge in the wrong direction Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/virtual_keyboard_controller.cc ('k') | chrome/browser/about_flags.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/virtual_keyboard_controller_unittest.cc
diff --git a/ash/virtual_keyboard_controller_unittest.cc b/ash/virtual_keyboard_controller_unittest.cc
index 7fb157e4453d824ee8f201b4626f95894f18388a..3956022a80b3fee3bf40763059ba45a10328fa4d 100644
--- a/ash/virtual_keyboard_controller_unittest.cc
+++ b/ash/virtual_keyboard_controller_unittest.cc
@@ -51,8 +51,6 @@ class VirtualKeyboardControllerTest : public AshTestBase {
}
void SetUp() override {
- base::CommandLine::ForCurrentProcess()->AppendSwitch(
- keyboard::switches::kDisableSmartVirtualKeyboard);
AshTestBase::SetUp();
UpdateKeyboardDevices(std::vector<ui::InputDevice>());
UpdateTouchscreenDevices(std::vector<ui::TouchscreenDevice>());
@@ -62,18 +60,6 @@ class VirtualKeyboardControllerTest : public AshTestBase {
DISALLOW_COPY_AND_ASSIGN(VirtualKeyboardControllerTest);
};
-TEST_F(VirtualKeyboardControllerTest, EnabledDuringMaximizeMode) {
- ASSERT_FALSE(keyboard::IsKeyboardEnabled());
- // Toggle maximized mode on.
- Shell::Get()->maximize_mode_controller()->EnableMaximizeModeWindowManager(
- true);
- EXPECT_TRUE(keyboard::IsKeyboardEnabled());
- // Toggle maximized mode off.
- Shell::Get()->maximize_mode_controller()->EnableMaximizeModeWindowManager(
- false);
- EXPECT_FALSE(keyboard::IsKeyboardEnabled());
-}
-
// Mock event blocker that enables the internal keyboard when it's destructor
// is called.
class MockEventBlocker : public ScopedDisableInternalMouseAndKeyboard {
« no previous file with comments | « ash/virtual_keyboard_controller.cc ('k') | chrome/browser/about_flags.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698