Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2869243003: Revert of CHECK that the RendererCompositorFrameSink has been detached (Closed)

Created:
3 years, 7 months ago by danakj
Modified:
3 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of CHECK that the RendererCompositorFrameSink has been detached (patchset #2 id:20001 of https://codereview.chromium.org/2763633002/ ) Reason for revert: Did not turn up anything. Original issue's description: > CHECK that the RendererCompositorFrameSink has been detached > > If it is not detached but is destroyed, then IPC messages incoming > to it would crash. > > R=piman@chromium.org > BUG=702764 > > Review-Url: https://codereview.chromium.org/2763633002 > Cr-Commit-Position: refs/heads/master@{#458164} > Committed: https://chromium.googlesource.com/chromium/src/+/cf54df64103c96335b138a924e185b0120c58d47 TBR=piman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=702764 Review-Url: https://codereview.chromium.org/2869243003 Cr-Commit-Position: refs/heads/master@{#470713} Committed: https://chromium.googlesource.com/chromium/src/+/d2aa1919a5b332bfcd64976a870a8edbf514c1f0

Patch Set 1 #

Patch Set 2 : revert: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M content/renderer/gpu/renderer_compositor_frame_sink.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/gpu/renderer_compositor_frame_sink.cc View 1 3 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
danakj
Created Revert of CHECK that the RendererCompositorFrameSink has been detached
3 years, 7 months ago (2017-05-10 14:56:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2869243003/1
3 years, 7 months ago (2017-05-10 14:57:08 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/449848)
3 years, 7 months ago (2017-05-10 15:02:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2869243003/70001
3 years, 7 months ago (2017-05-10 16:19:15 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/440854)
3 years, 7 months ago (2017-05-10 18:50:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2869243003/70001
3 years, 7 months ago (2017-05-10 19:52:14 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 21:20:57 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:70001) as
https://chromium.googlesource.com/chromium/src/+/d2aa1919a5b332bfcd64976a870a...

Powered by Google App Engine
This is Rietveld 408576698