Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 2763633002: CHECK that the RendererCompositorFrameSink has been detached (Closed)

Created:
3 years, 9 months ago by danakj
Modified:
3 years, 9 months ago
Reviewers:
piman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

CHECK that the RendererCompositorFrameSink has been detached If it is not detached but is destroyed, then IPC messages incoming to it would crash. R=piman@chromium.org BUG=702764 Review-Url: https://codereview.chromium.org/2763633002 Cr-Commit-Position: refs/heads/master@{#458164} Committed: https://chromium.googlesource.com/chromium/src/+/cf54df64103c96335b138a924e185b0120c58d47

Patch Set 1 #

Patch Set 2 : check-bound: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M content/renderer/gpu/renderer_compositor_frame_sink.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/gpu/renderer_compositor_frame_sink.cc View 1 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
danakj
3 years, 9 months ago (2017-03-20 15:39:12 UTC) #1
piman
lgtm
3 years, 9 months ago (2017-03-20 20:06:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763633002/20001
3 years, 9 months ago (2017-03-20 20:11:29 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/cf54df64103c96335b138a924e185b0120c58d47
3 years, 9 months ago (2017-03-20 20:19:18 UTC) #13
danakj
3 years, 7 months ago (2017-05-10 14:56:40 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2869243003/ by danakj@chromium.org.

The reason for reverting is: Did not turn up anything..

Powered by Google App Engine
This is Rietveld 408576698