Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2012)

Unified Diff: content/renderer/gpu/renderer_compositor_frame_sink.cc

Issue 2869243003: Revert of CHECK that the RendererCompositorFrameSink has been detached (Closed)
Patch Set: revert: . Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/gpu/renderer_compositor_frame_sink.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/gpu/renderer_compositor_frame_sink.cc
diff --git a/content/renderer/gpu/renderer_compositor_frame_sink.cc b/content/renderer/gpu/renderer_compositor_frame_sink.cc
index 1d28f324497bc78f811a05d4e46036e2863a8043..f06784c42a312865cc027ea7ac8d7d73b27e29d7 100644
--- a/content/renderer/gpu/renderer_compositor_frame_sink.cc
+++ b/content/renderer/gpu/renderer_compositor_frame_sink.cc
@@ -80,11 +80,7 @@ RendererCompositorFrameSink::RendererCompositorFrameSink(
EstablishMojoConnection();
}
-RendererCompositorFrameSink::~RendererCompositorFrameSink() {
- // TODO(crbug.com/702764): If not detached then IPC messages would crash
- // after this class is destroyed.
- CHECK(!bound_);
-}
+RendererCompositorFrameSink::~RendererCompositorFrameSink() = default;
bool RendererCompositorFrameSink::BindToClient(
cc::CompositorFrameSinkClient* client) {
@@ -106,8 +102,6 @@ bool RendererCompositorFrameSink::BindToClient(
compositor_frame_sink_proxy_);
compositor_frame_sink_filter_->AddHandlerOnCompositorThread(
routing_id_, compositor_frame_sink_filter_handler_);
-
- bound_ = true;
return true;
}
@@ -124,7 +118,6 @@ void RendererCompositorFrameSink::DetachFromClient() {
sink_.reset();
sink_client_binding_.Close();
cc::CompositorFrameSink::DetachFromClient();
- bound_ = false;
}
void RendererCompositorFrameSink::SubmitCompositorFrame(
« no previous file with comments | « content/renderer/gpu/renderer_compositor_frame_sink.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698