Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2868793002: Delete MessageViews cleared by "Clear All" after animation. (Closed)

Created:
3 years, 7 months ago by yhanada
Modified:
3 years, 7 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete MessageViews cleared by "Clear All" after animation. BUG=719336 TEST=Added unittests in message_center_unittests. Review-Url: https://codereview.chromium.org/2868793002 Cr-Commit-Position: refs/heads/master@{#469955} Committed: https://chromium.googlesource.com/chromium/src/+/051bc03146abba0fa2f15331e8ea04e0d3d98d92

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M ui/message_center/views/message_list_view.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/message_center/views/message_list_view_unittest.cc View 2 chunks +6 lines, -10 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
yhanada
PTAL. Thanks!
3 years, 7 months ago (2017-05-08 07:26:58 UTC) #3
yoshiki
LGTM. Thanks!
3 years, 7 months ago (2017-05-08 10:41:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2868793002/1
3 years, 7 months ago (2017-05-08 10:43:10 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 10:48:02 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/051bc03146abba0fa2f15331e8ea...

Powered by Google App Engine
This is Rietveld 408576698