Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2856833002: Fix a bug that old height is set in DoUpdateIfPossible(). (Closed)

Created:
3 years, 7 months ago by yhanada
Modified:
3 years, 7 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org, Eliot Courtney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a bug that old height is set in DoUpdateIfPossible(). - Call SetSize() after calculating the new height. - Add basic unittests for MessageListView::RemoveNotificationAt and MessageListView::ClearAllClosableNotifications. TEST=message_center_unittests pass. BUG=719305 Review-Url: https://codereview.chromium.org/2856833002 Cr-Commit-Position: refs/heads/master@{#469916} Committed: https://chromium.googlesource.com/chromium/src/+/4fa0cb2c01a36ea42448397b360dd3c39de36159

Patch Set 1 #

Patch Set 2 : Remove the unnecessary empty line #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -3 lines) Patch
M ui/message_center/views/message_list_view.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M ui/message_center/views/message_list_view_unittest.cc View 4 chunks +77 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (14 generated)
yhanada
PTAL.
3 years, 7 months ago (2017-05-02 08:11:40 UTC) #6
yoshiki
Thanks, Could you create a bug for reference? Then, LGTM
3 years, 7 months ago (2017-05-02 09:16:30 UTC) #9
yhanada
On 2017/05/02 09:16:30, yoshiki wrote: > Thanks, Could you create a bug for reference? Then, ...
3 years, 7 months ago (2017-05-08 04:02:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856833002/40001
3 years, 7 months ago (2017-05-08 04:03:10 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/378414) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 7 months ago (2017-05-08 04:55:01 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2856833002/40001
3 years, 7 months ago (2017-05-08 06:28:11 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 07:49:37 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4fa0cb2c01a36ea42448397b360d...

Powered by Google App Engine
This is Rietveld 408576698