Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2864293002: Add a regression test for crbug.com/713983. (Closed)

Created:
3 years, 7 months ago by yhanada
Modified:
3 years, 7 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a regression test for crbug.com/713983. BUG=713983 TEST=Reverting http://crrev.com/2836023002 makes this test crash. Review-Url: https://codereview.chromium.org/2864293002 Cr-Commit-Position: refs/heads/master@{#469957} Committed: https://chromium.googlesource.com/chromium/src/+/73029ea45937488ac4b586f759856682db1e3962

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
M ui/message_center/views/message_list_view_unittest.cc View 1 chunk +41 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
yhanada
PTAL. Thanks!
3 years, 7 months ago (2017-05-08 10:36:49 UTC) #6
yoshiki
Thank you for adding a test! LGTM
3 years, 7 months ago (2017-05-08 10:42:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864293002/1
3 years, 7 months ago (2017-05-08 10:50:07 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 10:53:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/73029ea45937488ac4b586f75985...

Powered by Google App Engine
This is Rietveld 408576698